search

kubernetes / cloud-provider-openstack

Apache License 2.0
616 stars 603 forks source link

[cinder-csi-plugin] Add metadata in creation of volume #2436

Closed Kortekaasy closed 1 month ago

Kortekaasy commented 11 months ago

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug /kind feature

What happened: My cloud provider uses the metadata field in the volume creation API call to enable e.g. encrypted volumes. Looking at the documentation & source code, it doesn't look like it's possible at this moment to such metadata to a PVC. If this is really not possible at the moment, could anyone give me some pointers on where to start to add such functionality?

kayrus commented 11 months ago

See also #2327.

jichenjc commented 11 months ago

@kayrus I assume you are talking about https://github.com/kubernetes/cloud-provider-openstack/issues/2327#issuecomment-1735749569 ? want to split the design of LB and CSI into different issue and can cross link

https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/csi/cinder/controllerserver.go#L107 is something we can refer to

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Kortekaasy commented 6 months ago

I see that this is somewhat related to https://github.com/kubernetes/cloud-provider-openstack/issues/2327#issuecomment-1735749569, but I also see development has stagnated there. If I were to implement adding metadata to volume creation, could anyone give me some pointers?

Kortekaasy commented 6 months ago

/remove-lifecycle rotten

dulek commented 6 months ago

I see that this is somewhat related to #2327 (comment), but I also see development has stagnated there. If I were to implement adding metadata to volume creation, could anyone give me some pointers?

At a glance I'd say it's almost implemented at [1]. What you would need to add is to read some more annotations at [2] (and maybe [3], but ephemeral volumes might not need that?) and pass them to properties variable. On the implementation PR we'll probably spend some time figuring out how to properly name the annotation itself.

[1] https://github.com/kubernetes/cloud-provider-openstack/blob/e87f50614b96a6af6095660aa6a77457223b344b/pkg/csi/cinder/openstack/openstack_volumes.go#L66-L68 [2] https://github.com/kubernetes/cloud-provider-openstack/blob/e87f50614b96a6af6095660aa6a77457223b344b/pkg/csi/cinder/controllerserver.go#L105-L112 [3] https://github.com/kubernetes/cloud-provider-openstack/blob/e87f50614b96a6af6095660aa6a77457223b344b/pkg/csi/cinder/nodeserver.go#L130

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 month ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/cloud-provider-openstack/issues/2436#issuecomment-2284513272): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.