search

kubernetes / cloud-provider-openstack

Apache License 2.0
615 stars 603 forks source link

cinder-csi: consider using ClusterFirstWithHostNet DNSPolicy #2574

Closed rptaylor closed 5 months ago

rptaylor commented 5 months ago

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened: Cinder CSI is using ClusterFirst DNSPolicy, but also appears to use hostNetwork. Following up from https://github.com/kubernetes/cloud-provider-openstack/issues/1387#issuecomment-2052269578 , it seems like using ClusterFirstWithHostNet could be better but it's not entirely clear to me. FYI @jichenjc

Anything else we need to know?: See https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy

Environment:

dulek commented 5 months ago

Seems like the chart has this configurable [1] and the default is in fact ClusterFirstWithHostNet [2]. This got fixed in #2483. What am I missing?

[1] https://github.com/kubernetes/cloud-provider-openstack/blob/8a156e543ca44924a5f26aaf001fb86bcbd100f9/charts/cinder-csi-plugin/templates/nodeplugin-daemonset.yaml#L27 [2] https://github.com/kubernetes/cloud-provider-openstack/blob/d64cd51353b0620dacf2aea868e0b282bb92fded/charts/cinder-csi-plugin/values.yaml#L72

rptaylor commented 5 months ago

Oh, good to see it was already discussed. I guess the recent comment https://github.com/kubernetes/cloud-provider-openstack/issues/1387#issuecomment-2052269578 mislead us then.