search

kubernetes / cloud-provider-openstack

Apache License 2.0
599 stars 597 forks source link

[cinder-csi-plugin] ephemeral volume removal #2602

Open sergelogvinov opened 1 month ago

sergelogvinov commented 1 month ago

Disable creating new deprecated ephemeral volumes

What this PR does / why we need it:

Remove deprecated ephemeral volumes.

Which issue this PR fixes(if applicable): fixes #2599

Special notes for reviewers:

Hi, @dulek i've disabled only ephemeral volume creation stage. What do you think, we should remove all code or make it in two steps (releases)?

Thanks.

Release note:

In-line ephemeral is no longer available.
k8s-ci-robot commented 1 month ago

Hi @sergelogvinov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jichenjc commented 1 month ago

/ok-to-test

jichenjc commented 1 month ago

thanks for the PR, could you please update

sergelogvinov commented 1 month ago

/retest-required

jichenjc commented 1 month ago

@sergelogvinov from the error seems more clean up needed, maybe sainty test cases?

sergelogvinov commented 1 month ago

@jichenjc All tests passed. thanks.

jichenjc commented 1 month ago

/approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/OWNERS)~~ [jichenjc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment