kubernetes / cloud-provider-openstack

Apache License 2.0
623 stars 611 forks source link

[cinder-csi-plugin] Add extraEnv support on cinder-csi-plugin and manila-csi-plugin helm charts #2613

Closed pli01 closed 5 months ago

pli01 commented 6 months ago

What this PR does / why we need it:

Add extraEnv support on the cinder-csi-plugin helm chart.

Which issue this PR fixes(if applicable):

Special notes for reviewers:

One example use case of extraEnv: In some of our private customer cloud, cinder-csi-plugin must access the openstack API endpoint with following env variable http_proxy, https_proxy, no_proxy.

Release note:

NONE
k8s-ci-robot commented 6 months ago

Welcome @pli01!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 6 months ago

Hi @pli01. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dulek commented 5 months ago

/ok-to-test

Looks like this could be useful for the Manila CSI charts too? Could you add it there as well?

pli01 commented 5 months ago

Looks like this could be useful for the Manila CSI charts too? Could you add it there as well?

Thanks for the approval. Yes, i will try to add here also the modification for Manila CSI charts.

pli01 commented 5 months ago

Added for manila @dulek , Is that okay with you ?

dulek commented 5 months ago

Looks good, just why do you comment out Manila's values.yaml, but not Cinder's?

pli01 commented 5 months ago

Looks good, just why do you comment out Manila's values.yaml, but not Cinder's?

mistake

it s now fixed

jichenjc commented 5 months ago

/approve

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/OWNERS)~~ [jichenjc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dulek commented 5 months ago

/lgtm