Closed pli01 closed 5 months ago
Welcome @pli01!
It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @pli01. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Looks like this could be useful for the Manila CSI charts too? Could you add it there as well?
Looks like this could be useful for the Manila CSI charts too? Could you add it there as well?
Thanks for the approval. Yes, i will try to add here also the modification for Manila CSI charts.
Added for manila @dulek , Is that okay with you ?
Looks good, just why do you comment out Manila's values.yaml, but not Cinder's?
Looks good, just why do you comment out Manila's values.yaml, but not Cinder's?
mistake
it s now fixed
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jichenjc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What this PR does / why we need it:
Add
extraEnv
support on the cinder-csi-plugin helm chart.Which issue this PR fixes(if applicable):
Special notes for reviewers:
One example use case of extraEnv: In some of our private customer cloud, cinder-csi-plugin must access the openstack API endpoint with following env variable
http_proxy, https_proxy, no_proxy
.Release note: