search

kubernetes / cloud-provider-openstack

Apache License 2.0
599 stars 597 forks source link

Add two test cases for OCCM #2614

Open dd-georgiev opened 1 month ago

dd-georgiev commented 1 month ago

What this PR does / why we need it: I added test cases for testing:

  1. The preservation of floating IPs when the loadbalancer.openstack.org/keep-floatingip: "true" annotation is added to service
  2. Basic checks for healthmonitors created via service annotations.
k8s-ci-robot commented 1 month ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
linux-foundation-easycla[bot] commented 1 month ago

CLA Not Signed

k8s-ci-robot commented 1 month ago

Hi @dd-georgiev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dd-georgiev commented 4 weeks ago

/ok-to-test

Looks like you need to solve EasyCLA here.

Interesting, I signed the document (in docusign) multiple times but it still doesn't show up here.

dulek commented 4 weeks ago

/easycla

Let's retry. You can also try checking the troubleshooting page. E.g. I had issues, because I was sending commits signed with a different email than the one I had in GitHub.

dulek commented 4 weeks ago

/test pull-cloud-provider-openstack-check

This one's stuck.

jichenjc commented 4 weeks ago

/easycla

jichenjc commented 4 weeks ago

/lgtm

k8s-ci-robot commented 2 weeks ago

New changes are detected. LGTM label has been removed.

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jichenjc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment