search

kubernetes / cloud-provider-openstack

Apache License 2.0
623 stars 611 forks source link

[occm] Revert dnsPolicy to Default for occm #2621

Closed zetaab closed 4 months ago

zetaab commented 5 months ago

What this PR does / why we need it: reverts the behaviour that was added https://github.com/kubernetes/cloud-provider-openstack/pull/2594

Which issue this PR fixes(if applicable): fixes #2611

Special notes for reviewers: if dnsPolicy is defined the default value is not Default its ClusterFirst. See https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy

Release note:

NONE
zetaab commented 5 months ago

cc @mdbooth @jichenjc

zetaab commented 5 months ago

/test openstack-cloud-controller-manager-e2e-test /test openstack-cloud-controller-manager-ovn-e2e-test

zetaab commented 5 months ago

/test pull-cloud-provider-openstack-check

jichenjc commented 5 months ago

/test openstack-cloud-controller-manager-e2e-test /test openstack-cloud-controller-manager-ovn-e2e-test

jichenjc commented 4 months ago

/lgtm /approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/OWNERS)~~ [jichenjc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment