search

kubernetes / cloud-provider-openstack

Apache License 2.0
599 stars 597 forks source link

[occm] Revert dnsPolicy to Default for occm #2621

Open zetaab opened 3 days ago

zetaab commented 3 days ago

What this PR does / why we need it: reverts the behaviour that was added https://github.com/kubernetes/cloud-provider-openstack/pull/2594

Which issue this PR fixes(if applicable): fixes #2611

Special notes for reviewers: if dnsPolicy is defined the default value is not Default its ClusterFirst. See https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy

Release note:

NONE
k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from zetaab. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zetaab commented 3 days ago

cc @mdbooth @jichenjc

zetaab commented 3 days ago

/test openstack-cloud-controller-manager-e2e-test /test openstack-cloud-controller-manager-ovn-e2e-test

zetaab commented 3 days ago

/test pull-cloud-provider-openstack-check

jichenjc commented 3 days ago

/test openstack-cloud-controller-manager-e2e-test /test openstack-cloud-controller-manager-ovn-e2e-test