kubernetes / cloud-provider-openstack

Apache License 2.0
623 stars 611 forks source link

openstack-cloud-controller-manager-binary does not show the correct release in OKD/OCP4.12+ #2623

Open jonasbartho opened 4 months ago

jonasbartho commented 4 months ago

Is this a BUG REPORT or FEATURE REQUEST?: /kind bug

What happened: The openstack-cloud-controller-manager binary in OKD 4.12(=free version of Openshift) does not show the correct git-release that is being used.

# openstack-cloud-controller-manager --version Kubernetes v0.0.0-master+$Format:%H$

What you expected to happen: Since openstack-cloud-controller-manager is the out-of-tree provider of Openstack by default in OKD/OCP4.12+, it would be nice to see which version it is using. I for example want to use new functionality from release-1.30, but it looks like it is not available yet. Is there any other way to check which release I am on?

Environment:

jonasbartho commented 4 months ago

I found the following command that gives sort-of a hunch which version currently is being used:

$ oc adm release info --commit-urls |grep -i openstack-cloud
  openstack-cloud-controller-manager             https://github.com/openshift/cloud-provider-openstack/commit/e1a9f48173b0056dc96b62ef6b141ccc1838cebc
jichenjc commented 4 months ago

openstack-cloud-controller-manager --version

Kubernetes v0.0.0-master+$Format:%H$

I remember it's a known issue and somehow related to Cloud provider instead of OCCM but not 100% sure now

kayrus commented 4 months ago

I remember that I fixed this last year in #2252

I just checked the 1.30 release:

$ docker run --rm --entrypoint /bin/openstack-cloud-controller-manager registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.30.0 --version
Kubernetes v1.30.0
k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 9 hours ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten