search

kubernetes / cloud-provider-openstack

Apache License 2.0
623 stars 611 forks source link

[release-1.30] [cinder-csi]: allow node service to run without openstack client #2656

Closed kayrus closed 2 months ago

kayrus commented 2 months ago

What this PR does / why we need it:

This PR allows to run cinder-csi-plugin node service without requiring the openstack credentials.

Which issue this PR fixes(if applicable): fixes #2599 backport of the #2655

Special notes for reviewers:

This PR will be used to make backports to 1.29, 1.28

Release note:

This PR is intended to improve the cinder CSI driver security.

[cinder-csi]: allow node service to run without openstack client
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.30/OWNERS)~~ [zetaab] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zetaab commented 2 months ago

/lgtm

kayrus commented 2 months ago

/cherry-pick release-1.29

k8s-infra-cherrypick-robot commented 2 months ago

@kayrus: once the present PR merges, I will cherry-pick it on top of release-1.29 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes/cloud-provider-openstack/pull/2656#issuecomment-2357817788): >/cherry-pick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kayrus commented 2 months ago

/cherry-pick release-1.28

k8s-infra-cherrypick-robot commented 2 months ago

@kayrus: once the present PR merges, I will cherry-pick it on top of release-1.28 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes/cloud-provider-openstack/pull/2656#issuecomment-2357817939): >/cherry-pick release-1.28 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 2 months ago

@kayrus: #2656 failed to apply on top of branch "release-1.29":

Applying: allow node service to run without openstack client
Using index info to reconstruct a base tree...
M   cmd/cinder-csi-plugin/main.go
M   docs/cinder-csi-plugin/using-cinder-csi-plugin.md
M   pkg/csi/cinder/openstack/openstack.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/csi/cinder/openstack/openstack.go
Auto-merging docs/cinder-csi-plugin/using-cinder-csi-plugin.md
CONFLICT (content): Merge conflict in docs/cinder-csi-plugin/using-cinder-csi-plugin.md
Auto-merging cmd/cinder-csi-plugin/main.go
CONFLICT (content): Merge conflict in cmd/cinder-csi-plugin/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 allow node service to run without openstack client
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes/cloud-provider-openstack/pull/2656#issuecomment-2357817788): >/cherry-pick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 2 months ago

@kayrus: #2656 failed to apply on top of branch "release-1.28":

Applying: allow node service to run without openstack client
Using index info to reconstruct a base tree...
M   cmd/cinder-csi-plugin/main.go
M   docs/cinder-csi-plugin/using-cinder-csi-plugin.md
M   pkg/csi/cinder/openstack/openstack.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/csi/cinder/openstack/openstack.go
Auto-merging docs/cinder-csi-plugin/using-cinder-csi-plugin.md
CONFLICT (content): Merge conflict in docs/cinder-csi-plugin/using-cinder-csi-plugin.md
Auto-merging cmd/cinder-csi-plugin/main.go
CONFLICT (content): Merge conflict in cmd/cinder-csi-plugin/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 allow node service to run without openstack client
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes/cloud-provider-openstack/pull/2656#issuecomment-2357817939): >/cherry-pick release-1.28 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kayrus commented 2 months ago

/cherry-pick release-1.29

k8s-infra-cherrypick-robot commented 2 months ago

@kayrus: new pull request created: #2668

In response to [this](https://github.com/kubernetes/cloud-provider-openstack/pull/2656#issuecomment-2358373173): >/cherry-pick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.