Open guillaumebernard84 opened 1 month ago
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kayrus for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @guillaumebernard84. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
PR needs rebase.
What this PR does / why we need it:
Hello, this PR modifies the openstack-cinder-csi helm chart to allow to use it with the multi cloud feature: https://github.com/kubernetes/cloud-provider-openstack/pull/2551
It fixes two problems that were preventing to use the chart with multi cloud: 1) When runing the cinder-csi-plugin with multi-region, you need to specify different
extraArgs
on thecinder-csi-plugin
containers of the deployment and the daemonset. It wasn't possible with the current version. Now you can, like this:You still need to create the second daemonset manually, but at least you can use the chart. If this PR is accepted, I'll work on a new one to allow the creation of the second daemonset.
2) If you use the
resizer
and thesnapshotter
, you will need them to be able to read the secrets you defined in the storage class' annotations in order to determine which cloud to address. This was hardcoded in controllerplugin-rbac.yaml, now you can specify it like this:I also moved the comments from controllerplugin-rbac.yaml to the values file.
I added these info to the multi-region-clouds.md documentation file.