kubernetes / cloud-provider-openstack

Apache License 2.0
623 stars 611 forks source link

[occm] Support Octavia load balancing method via annotation #2684

Closed Lucasgranet closed 5 days ago

Lucasgranet commented 1 month ago

What this PR does / why we need it: Adds the ability to change the LB Algorithm of an Octavia using an annotation.

This PR brings a new annotation:

loadbalancer.openstack.org/lb-method: "" # Default value: the one defined in the OCCM configuration file

Special notes for reviewers: N/A

Release note:

[occm] Octavia - ability to change the load balancing method using an annotation.
k8s-ci-robot commented 1 month ago

Hi @Lucasgranet. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nicolaslacroux commented 1 month ago

Hello,

If you have some time, would you mind reviewing this PR please?

Thank you,

Lucasgranet commented 3 weeks ago

Hello @kayrus

I've applied all your suggestions.

k8s-ci-robot commented 1 week ago

@Lucasgranet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-csi-cinder-e2e-test 203ad01845f5249e76fb1e270a6487997b9d518f link true /test openstack-cloud-csi-cinder-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/OWNERS)~~ [zetaab] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment