search

kubernetes / cloud-provider-openstack

Apache License 2.0
623 stars 611 forks source link

[occm] fix node internal/external IP order #2719

Closed kayrus closed 1 week ago

kayrus commented 1 week ago

What this PR does / why we need it:

This PR fixes a regression introduced in #2688, unit tests ensure that the internal/external IP order works as expected.

Which issue this PR fixes(if applicable): fixes #2718

Special notes for reviewers:

Release note:

NONE
kayrus commented 1 week ago

@zetaab @dulek ready for review

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/openstack/OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/openstack/OWNERS)~~ [zetaab] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment