search

kubernetes / cloud-provider-openstack

Apache License 2.0
616 stars 601 forks source link

The components miss a kustomization.yaml #987

Closed chrischdi closed 3 years ago

chrischdi commented 4 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug /kind feature

The binaries affected:

What happened: I wanted to use the yaml files in:

and refer them directly in a local kustomization.yaml file. This does not work because the cloud-provider-openstack repository does not contain any kustomization file.

What you expected to happen: There is a kustomization file which I could refer to in my kustomization.yaml

How to reproduce it:

DEMO_HOME=$(mktemp -d)
cat <<EOF >$DEMO_HOME/kustomization.yaml
resources:
- github.com/kubernetes/cloud-provider-openstack/cluster/addons/rbac/
#- github.com/kubernetes-sigs/kustomize/examples/multibases?ref=v1.0.6
EOF
kubectl apply -k $DEMO_HOME

Anything else we need to know?:

Would it be reasonable to add kustomization.yaml files? If yes I would be happy to contribute :-)

Environment:

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

ramineni commented 4 years ago

/remove-lifecycle stale

chrischdi commented 4 years ago

@ramineni would it make sense to add simple kustomization.yaml files to each of the manifest directories? e.g. for the cinder csi plugin:

 resources:
- cinder-csi-controllerplugin-rbac.yaml
- cinder-csi-controllerplugin.yaml
- cinder-csi-nodeplugin-rbac.yaml
- cinder-csi-nodeplugin.yaml
- csi-cinder-driver.yaml
- csi-secret-cinderplugin.yaml

If so I would be happy to open a PR for that :-)

ramineni commented 4 years ago

@chrischdi That would be great. Please go ahead

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

ramineni commented 3 years ago

/remove-lifecycle rotten

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

ramineni commented 3 years ago

/remove-lifecycle stale

baylisscg commented 3 years ago

For anyone winding up here before a fix lands or who want to use an older version you can use something like:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - https://github.com/kubernetes/cloud-provider-openstack/raw/release-1.17/manifests/cinder-csi-plugin/cinder-csi-controllerplugin-rbac.yaml
  - https://github.com/kubernetes/cloud-provider-openstack/raw/release-1.17/manifests/cinder-csi-plugin/cinder-csi-controllerplugin.yaml
  - https://github.com/kubernetes/cloud-provider-openstack/raw/release-1.17/manifests/cinder-csi-plugin/cinder-csi-nodeplugin-rbac.yaml
  - https://github.com/kubernetes/cloud-provider-openstack/raw/release-1.17/manifests/cinder-csi-plugin/cinder-csi-nodeplugin.yaml
  - https://github.com/kubernetes/cloud-provider-openstack/raw/release-1.17/manifests/cinder-csi-plugin/csi-cinder-driver.yaml
  - https://github.com/kubernetes/cloud-provider-openstack/raw/release-1.17/manifests/cinder-csi-plugin/csi-secret-cinderplugin.yaml

just replace the release-1.17 with the appropriate tag.

lingxiankong commented 3 years ago

@baylisscg Thanks!

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/cloud-provider-openstack/issues/987#issuecomment-881778940): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.