search

kubernetes / cloud-provider-vsphere

Kubernetes Cloud Provider for vSphere https://cloud-provider-vsphere.sigs.k8s.io
Apache License 2.0
242 stars 176 forks source link

⚙️ Fix golang static check #1185

Closed XudongLiuHarold closed 2 months ago

XudongLiuHarold commented 2 months ago

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE
XudongLiuHarold commented 2 months ago

/cherry-pick release-1.29

k8s-infra-cherrypick-robot commented 2 months ago

@XudongLiuHarold: once the present PR merges, I will cherry-pick it on top of release-1.29 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1185#issuecomment-2293040705): >/cherry-pick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
DanielXiao commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DanielXiao, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-vsphere/blob/release-1.30/OWNERS)~~ [DanielXiao,XudongLiuHarold] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-infra-cherrypick-robot commented 2 months ago

@XudongLiuHarold: #1185 failed to apply on top of branch "release-1.29":

Applying: fix go static check
Using index info to reconstruct a base tree...
M   pkg/cloudprovider/vsphereparavirtual/loadbalancer_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloudprovider/vsphereparavirtual/loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/cloudprovider/vsphereparavirtual/loadbalancer_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix go static check
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1185#issuecomment-2293040705): >/cherry-pick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.