cloud provider vsphere pod didn't restart gracefully as expected

XudongLiuHarold commented 3 months ago

What happened?

In https://github.com/kubernetes/cloud-provider-vsphere/blob/master/cmd/vsphere-cloud-controller-manager/main.go#L273, cloud provider vsphere is using klog.Fatalf to log information, it will exit directly so the stop channel didn't receive the signal

klog.Fatalf("restarting pod because received event %v\n", event)
stopCh <- struct{}{}

What did you expect to happen?

The pod should not exit at klog.Fatalf and allow the signal to be send to the channel

How can we reproduce it (as minimally and precisely as possible)?

existing in current version

Anything else we need to know (please consider providing level 4 or above logs of CPI)?

No response

Kubernetes version

```console $ kubectl version # paste output here ```

v1.31.0

Cloud provider or hardware configuration

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Kernel (e.g. `uname -a`)

Install tools

Container runtime (CRI) and and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

Others

XudongLiuHarold commented 3 months ago

/assign

k8s-triage-robot commented 2 days ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

kubernetes / cloud-provider-vsphere