search

kubernetes / cloud-provider-vsphere

Kubernetes Cloud Provider for vSphere https://cloud-provider-vsphere.sigs.k8s.io
Apache License 2.0
244 stars 177 forks source link

Add support for MOID on datacenter field #1283

Closed rikatz closed 3 weeks ago

rikatz commented 3 weeks ago

What this PR does / why we need it: This PR adds support for MOID on the datacenter field, so the real object ID can be used instead of its canonical name

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Support for MOID on field names
rikatz commented 3 weeks ago

/assign @lubronzhan /cc @lubronzhan

lubronzhan commented 3 weeks ago

cc @DanielXiao @XudongLiuHarold this is for vanila k8s cluster

/approve /lgtm

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lubronzhan, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-vsphere/blob/master/OWNERS)~~ [lubronzhan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rikatz commented 3 weeks ago

/cherry-pick release-1.29

k8s-infra-cherrypick-robot commented 3 weeks ago

@rikatz: once the present PR merges, I will cherry-pick it on top of release-1.29 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1283#issuecomment-2450395889): >/cherry-pick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rikatz commented 3 weeks ago

/cherry-pick release-1.30

k8s-infra-cherrypick-robot commented 3 weeks ago

@rikatz: once the present PR merges, I will cherry-pick it on top of release-1.30 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1283#issuecomment-2450396247): >/cherry-pick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rikatz commented 3 weeks ago

/cherry-pick release-1.31

k8s-infra-cherrypick-robot commented 3 weeks ago

@rikatz: once the present PR merges, I will cherry-pick it on top of release-1.31 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1283#issuecomment-2450396491): >/cherry-pick release-1.31 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 weeks ago

@rikatz: new pull request created: #1284

In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1283#issuecomment-2450396247): >/cherry-pick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 weeks ago

@rikatz: new pull request created: #1285

In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1283#issuecomment-2450396491): >/cherry-pick release-1.31 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 weeks ago

@rikatz: new pull request created: #1286

In response to [this](https://github.com/kubernetes/cloud-provider-vsphere/pull/1283#issuecomment-2450395889): >/cherry-pick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.