search

kubernetes / committee-security-response

Kubernetes Security Process and Security Committee docs
Apache License 2.0
165 stars 65 forks source link

Add a tool to consistently format embargoed patches #197

Closed cji closed 5 months ago

cji commented 6 months ago

Fixes #189

I tested this with the most recent round of embargoed patches, but would encourage reviewers to test for others as well if you have the time please.

Feedback welcome on making this seem like less of a hack, but this was a quick way I got it worked as expected.

ritazh commented 5 months ago

One nit to add a comment, otherwise LGTM

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cji, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/committee-security-response/blob/main/OWNERS)~~ [cji,ritazh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cji commented 5 months ago

Thank you @ritazh!