search

kubernetes / community

Kubernetes community content
Apache License 2.0
11.88k stars 5.14k forks source link

api-conventions.md should explain patchStrategy #3752

Open MikeSpreitzer opened 5 years ago

MikeSpreitzer commented 5 years ago

The API conventions doc should explain, or point to an explanation of, the patchStrategy stuff that appears in golang. The reader should be told how to understand the existing golang, and how to use patchStrategy when writing new golang. This should include a pointer to the definitions of what each patchStrategy means.

MikeSpreitzer commented 5 years ago

@kubernetes/sig-api-machinery-misc

nikhita commented 5 years ago

Adding sig-arch as well because they own the doc /sig architecture /kind documentation

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

MikeSpreitzer commented 4 years ago

/remove-lifecycle rotten

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

MikeSpreitzer commented 4 years ago

/remove-lifecycle stale still current, see #87594

lavalamp commented 4 years ago

/assign @apelisse

lavalamp commented 4 years ago

Since we should also explain the new way.

apelisse commented 4 years ago

Should be fixed by #4218

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 4 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/community/issues/3752#issuecomment-670988594): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lavalamp commented 4 years ago

/reopen /lifecycle frozen

k8s-ci-robot commented 4 years ago

@lavalamp: Reopened this issue.

In response to [this](https://github.com/kubernetes/community/issues/3752#issuecomment-671449119): >/reopen >/lifecycle frozen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fedebongio commented 2 years ago

/assign @apelisse @MikeSpreitzer

thockin commented 2 years ago

+100000

lavalamp commented 2 years ago

Note that we should also recommend the newer SSA version of these concepts.

I don't know if we can realistically get rid of SMP, or even officially deprecate it, at least not soon -- but it has bugs we don't intend to fix.

thockin commented 2 years ago

Mostly I find myself confused which values are available for which tags, what the semantics of them are, and how they intersect between SMP and SSA

On Wed, Mar 30, 2022 at 9:39 AM Daniel Smith @.***> wrote:

Note that we should also recommend the newer SSA version of these concepts.

I don't know if we can realistically get rid of SMP, or even officially deprecate it, at least not soon -- but it has bugs we don't intend to fix.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/community/issues/3752#issuecomment-1083370890, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKWAVCNHYLNI6WIAUPGT7LVCR7STANCNFSM4HR4OURQ . You are receiving this because you commented.Message ID: @.***>