kubernetes / community

Kubernetes community content
Apache License 2.0
11.91k stars 5.16k forks source link

[Discussion] Remove language that might come across inconsiderate #4399

Closed mariantalla closed 3 years ago

mariantalla commented 4 years ago

Inspiration for this comes from other open-source projects: https://github.com/facebook/jest/commit/59f6e3fd3fe6b502100a9c91ea22e91fe554136b and https://github.com/pivotal/docs-concourse-pcf/pull/22.

A quick and very superficial search brings back a pretty big number of occurrences of just/simple/simply/of course etc. - however, other than that, I haven't thoroughly looked into how frequently they pop up, and I haven't done any work whatsoever to gauge what the impact might be at the moment.

For now, I'm curious to hear what feedback or other input folks have on this, and we can talk complexity and next steps if we think it makes sense in principle.

mariantalla commented 4 years ago

/sig contributor-experience /sig docs seem like the most appropriate ones πŸ€”

parispittman commented 4 years ago

+1, on board. very considerate discussion topic ;) thanks for bringing this up @mariantalla

mariantalla commented 4 years ago

I see what you did there πŸ™ƒ

dims commented 4 years ago

LOL +1 :)

mrbobbytables commented 4 years ago

+1 As well. Outside of being potentially inconsiderate, omitting unnecessary adverbs improves readability and helps non-native english speakers.

/cc @zacharysarah @jimangel @Bradamant3 For comments from docs πŸ‘

zacharysarah commented 4 years ago

+1

Can we get rid of master and slave while we’re at it?

jimangel commented 4 years ago

BIG +1! Thanks @mariantalla!

parispittman commented 4 years ago

I don't think you'll see many folks disagree on principle. What about putting a plan together for the /community repo as a small(er) playground to test? If you want to recruit some folks to help (with plan or execution), mail this issue link to the contribex mailing list.

tmart333 commented 4 years ago

@mariantalla as a novice to github and a non-coder, I'd love to be involved in this. I subscribed to this issue... is there something else I should do to track this? :)

mbbroberg commented 4 years ago

Hey @mariantalla :wave:, ping me if I can help scope how to tackle this!

cblecker commented 4 years ago
mbbroberg commented 4 years ago

Jumping back in (thanks for the nudge @mariantalla!). Thinking process-wise, I could see this issue being reframed as a meta issue with the following checklist items:

I'll be hanging out in #sig-contribex on Slack if you want to through through it more in real-time. Alternatively, it might be helpful to spin up a #temp-inclusive-language as a temporary channel to work through the problem.

Throwing this out here to start and happy to see where we want to run with it πŸƒπŸƒ

mbbroberg commented 4 years ago

Looking through hound, I see a ton of just instances alone. They are, thankfully, not in a ton of repositories, so that could be the most natural separation for issues. For instance "Remove instances of uninclusive language from $REPO" as a template and that outlines the style guide updates.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

mrbobbytables commented 4 years ago

/remove-lifecycle stale Theres some traction here the efforts going into removing whitelist/blacklist. refs: https://github.com/kubernetes/website/pull/21591 https://github.com/kubernetes/kubernetes/issues/90277 https://github.com/kubernetes/kubernetes/pull/91927

celestehorgan commented 4 years ago

/wg naming

Duplicate/overlapping issue: https://github.com/kubernetes/website/issues/17070

mrbobbytables commented 3 years ago

@celestehorgan do you think we should close this issue and track in k/website or another issue?

celestehorgan commented 3 years ago

@mrbobbytables The correct escalation for this issue (at this point) is to take this to the WG Naming mailing list and propose, for each term to replace, a replacement (or to remove the language entirely, as it were).

I can take care of that and we can close this issue after?

/assign

mrbobbytables commented 3 years ago

That sgtm! Thanks for taking point :)

justaugustus commented 3 years ago

/unassign @celestehorgan /assign @zacharysarah

zacharysarah commented 3 years ago

Duplicate of https://github.com/kubernetes/website/issues/17070; I recommend closing this issue.

/close

k8s-ci-robot commented 3 years ago

@zacharysarah: Closing this issue.

In response to [this](https://github.com/kubernetes/community/issues/4399#issuecomment-722045456): >Duplicate of https://github.com/kubernetes/website/issues/17070; I recommend closing this issue. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.