search

kubernetes / community

Kubernetes community content
Apache License 2.0
12.03k stars 5.17k forks source link

PRs: document policy around fixing linter checks #8135

Closed pohly closed 2 weeks ago

pohly commented 3 weeks ago

Which issue(s) this PR fixes:

Occasionally contributors run linters, fix issues found by them (sometimes automatically!) and then create PRs. This creates work for maintainers and is often not useful, so let's write this down. Perhaps future contributors will find it, if not, we can point to it in PRs when closing them.

Related-to: https://github.com/kubernetes/kubernetes/pull/128350#issuecomment-2439631164

/assign @liggitt /cc @thockin

aojea commented 2 weeks ago

LGTM

thockin commented 2 weeks ago

/hold in case anyone else...

SergeyKanzhelev commented 2 weeks ago

Maybe also include some advice how to point to the approval from Slack or other places in PR description and mention specific people who appeoved

pohly commented 2 weeks ago

/hold in case anyone else...

Let's hold this another day and then I'll lift the hold.

dims commented 2 weeks ago

/approve /lgtm

dims commented 2 weeks ago

thanks for writing this up @pohly

thockin commented 2 weeks ago

Thanks for writing this

/lgtm /approve

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pohly, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[contributors/guide/OWNERS](https://github.com/kubernetes/community/blob/master/contributors/guide/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 2 weeks ago

/hold cancel