Closed fntlnz closed 3 years ago
Welcome @fntlnz!
It looks like this is your first PR to kubernetes-sigs/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/contributor-site has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Thanks for fixing that :D It's been a long standing issue. /lgtm /approve /pony yay
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, mrbobbytables
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi 🤗 !!
It was disabled in #131 because hugo is not using 1, however, the hugo project has been trying to update this but it always introduces regressions and they are having regressions with the JS minifier.
I felt like it was a good idea to restore the wide minification and only disable the svg one instead of disabling it completely.
I think this could also be contributed to docsy directly but I thought that doing it here would've been equally good since it's a temporary workaround.
Once hugo has
tdewolff/minify >= 2.7.3
we can just remove thenavbar.html
partial, I wrote a notice in the file about that too.Signed-off-by: Lorenzo Fontana lo@linux.com