kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
64 stars 153 forks source link

fix few minor typos #192

Closed rajatjindal closed 3 years ago

rajatjindal commented 3 years ago

while deprecating docker-server with container-serve (or container-server), there was some inconsistency.

e.g. in container-targets, it refers to container-server, while other places including the target itself, its used as container-serve.

container-targets: container-image container-gen-content container-render container-server
docker-server:
    @echo -e "**** The use of docker-render is deprecated. Use container-serve instead. ****" 1>&2
    $(MAKE) container-serve

container-serve: ## Run Hugo locally within a container, available at http://localhost:1313/

Please let me know if we want to keep it container-serve (if the change was intentional) or container-server (consistent with outgoing docker-server).

thanks

rajatjindal commented 3 years ago

requesting review from @castrojo @mrbobbytables

mrbobbytables commented 3 years ago

Thanks! /lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, rajatjindal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/contributor-site/blob/master/OWNERS)~~ [mrbobbytables] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment