search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
64 stars 153 forks source link

Chris' story: non-code contribution #205

Closed mbbroberg closed 3 years ago

mbbroberg commented 3 years ago

This is the first story to go live after we have an introduction post.

/cc @chris-short @mrbobbytables /sig contributor-experience /area contributor-comms /hold

k8s-ci-robot commented 3 years ago

@mbbroberg: The label(s) area/contributor-comms cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/kubernetes-sigs/contributor-site/pull/205): >This is the first story to go live after we have an introduction post. > >/cc @chris-short @mrbobbytables >/sig contributor-experience >/area contributor-comms >/hold Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chris-short commented 3 years ago

@mrbobbytables Your requested changes have been made.

mbbroberg commented 3 years ago

To publish after #215

mbbroberg commented 3 years ago

/lgtm

k8s-ci-robot commented 3 years ago

@mbbroberg: you cannot LGTM your own PR.

In response to [this](https://github.com/kubernetes/contributor-site/pull/205#issuecomment-821248661): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mbbroberg commented 3 years ago

Oops, you LGTM, not me @chris-short :)

chris-short commented 3 years ago

/lgtm

mbbroberg commented 3 years ago

As soon as #215 goes live, this will be ready to unhold.

chris-short commented 3 years ago

/lgtm

mrbobbytables commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chris-short, mbbroberg, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [mrbobbytables] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 3 years ago

Looks OK to unhold (to me)

chris-short commented 3 years ago

/unhold

sftim commented 3 years ago

@mbbroberg @chris-short I'll PR this to mirror it to https://blog.k8s.io/ too - unless either of you to would like to?

chris-short commented 3 years ago

Please do! Thank you.