kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
64 stars 153 forks source link

SIG Node CI Subproject Celebrates Two Years of Test Improvements #288

Closed SergeyKanzhelev closed 2 years ago

SergeyKanzhelev commented 2 years ago

See https://github.com/kubernetes/website/pull/31655

/sig node /language en

k8s-ci-robot commented 2 years ago

@SergeyKanzhelev: The label(s) language/en cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes/contributor-site/pull/288): >See https://github.com/kubernetes/website/pull/31655 > >/sig node >/language en > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sftim commented 2 years ago

Also LGTM

dchen1107 commented 2 years ago

LGTM from SIG Node perspective.

Thanks @SergeyKanzhelev, @ehashman and everyone participating in this effort. Great progress!

sftim commented 2 years ago

Latest deploy preview

sftim commented 2 years ago

Informal LGTM (I skimmed it)

SergeyKanzhelev commented 2 years ago

This post and https://github.com/kubernetes/website/pull/31655 cross-post are ready for publication

jberkus commented 2 years ago

/lgtm

SergeyKanzhelev commented 2 years ago

applied suggestions from @nate-double-u

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, matthyx, nate-double-u, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SergeyKanzhelev commented 2 years ago

/unhold