search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
64 stars 153 forks source link

blog:bot helper CI Job #293

Closed SubhasmitaSw closed 2 years ago

SubhasmitaSw commented 2 years ago

Reference #31919

k8s-ci-robot commented 2 years ago

Welcome @SubhasmitaSw!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

jberkus commented 2 years ago

Hey, thanks for this blog post! It looks great and will be really helpful for devs on Windows.

However, there are a bunch of formatting issues with it. One is that your use of sub-heads is odd and I don't think will flow well for the reader. The second is the lack of descriptions for any images. Finally, you use several different forms of code blocking, some of which I don't think work, unless they're special Hugo codes I don't know about.

Happy to help you revise this.

SubhasmitaSw commented 2 years ago

Hey, thanks for this blog post! It looks great and will be really helpful for devs on Windows.

However, there are a bunch of formatting issues with it. One is that your use of sub-heads is odd and I don't think will flow well for the reader. The second is the lack of descriptions for any images. Finally, you use several different forms of code blocking, some of which I don't think work, unless they're special Hugo codes I don't know about.

Happy to help you revise this.

I used formatting from the HackMd to which rendering seems problematic for the Github markdown. I have rectified a large portion of the things and added a description to conceivably every picture. Thanks for suggesting improvements and apology for being late.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, SubhasmitaSw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SubhasmitaSw commented 2 years ago

Looks good to me. Let's schedule it and merge it!

Please let me know where we shall communicate the schedule date either on slack or here itself.

sftim commented 2 years ago

Try to avoid merging long before the scheduled date due to https://github.com/kubernetes/contributor-site/issues/281

Also, please don't pick a date that's close to the v1.24 Kubernetes release.

SubhasmitaSw commented 2 years ago

Try to avoid merging long before the scheduled date due to https://github.com/kubernetes/contributor-site/issues/281

Also, please don't pick a date that's close to the v1.24 Kubernetes release.

The suggested date by @jberkus is 26/4.

sftim commented 2 years ago

Publishing on 2022-04-26 would be fine for the Kubernetes blog team. Ideally, update https://github.com/kubernetes/website/pull/31919 to match the text of this one as well, so we can get them both published close together.

jberkus commented 2 years ago

/lgtm

Let's publish now.