search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
64 stars 153 forks source link

Kubernetes 1.24: contextual logging blog post #304

Closed pohly closed 2 years ago

pohly commented 2 years ago

Contextual logging is an enhancement that landed as alpha in Kubernetes 1.24. Because it targets primarily developers of Kubernetes at this point, publishing it under https://k8s.dev/blog on the same day as it also gets published on the main blog (see https://github.com/kubernetes/website/pull/32656) makes sense.

pohly commented 2 years ago

/hold

Because of https://github.com/kubernetes/contributor-site/issues/281

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 2 years ago

Comments addressed, please take another look.

pohly commented 2 years ago

I have force-pushed an update to address the review feedback from https://github.com/kubernetes/website/pull/32656#pullrequestreview-958739741

jberkus commented 2 years ago

/lgtm

from me

pohly commented 2 years ago

The markup was wrong in at least one place and line breaks in link text looked odd, at least on GitHub. I've reformatted those.

When this lands in the blog, paragraphs will get reflown, right? I thought GitHub also did that, but apparently not.

sftim commented 2 years ago

Bear in mind that due to https://github.com/kubernetes/contributor-site/issues/281 this needs to be approved and LGTMed and then on the day of publication (not before), unheld.

pohly commented 2 years ago

@sftim, @jberkus : we are getting closer to the intended publishing data (25th of May). Is this good to go as it is?

Can we merge it now or unhold it on the day when it is supposed to go live (https://github.com/kubernetes/contributor-site/issues/281)?

sftim commented 2 years ago

We wouldn't merge it now. We should get the approvals and reviews in place so that an unhold on the day of publication is all ready to go.

sftim commented 2 years ago

We wouldn't merge it now. We should get the approvals and reviews in place so that an unhold on the day of publication is all ready to go.

Changes since https://github.com/kubernetes/contributor-site/pull/304#issuecomment-1115312087 look minor. /lgtm

sftim commented 2 years ago

Is https://github.com/kubernetes/website/pull/32656 level with the article text as reviewed here?

pohly commented 2 years ago

Is kubernetes/website#32656 level with the article text as reviewed here?

Not yet, but as this seems to be the final version now I'll copy it over.

pohly commented 2 years ago

/hold cancel

Let's publish...