kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
66 stars 149 forks source link

blog: meet our contributors APAC China region #314

Closed jayesh-srivastava closed 2 years ago

jayesh-srivastava commented 2 years ago

This PR adds the third blog post for China region, in the series of "Meet Our Contributors - APAC" blog series.

Reference issue: https://github.com/kubernetes/community/issues/4469#issuecomment-942422348

jberkus commented 2 years ago

Also ... are you sure you want to publish this on 6/11, a Saturday?

jayesh-srivastava commented 2 years ago

Also ... are you sure you want to publish this on 6/11, a Saturday?

Didn't think about this. Will change this to the 13th of June.

jayesh-srivastava commented 2 years ago

@jberkus Can you review this now please?

jberkus commented 2 years ago

Jayesh,

There's still some of the issues I called out in my first review.

sftim commented 2 years ago

If we want this mirrored onto https://k8s.io/blog/ (which is usual), please open a PR there once the final contents are agreed.

I suggest delaying a day or two to get that sorted. We can /hold this merge, get approvals, and then unhold it on publication day (cf https://github.com/kubernetes/contributor-site/issues/281)

jayesh-srivastava commented 2 years ago

/hold

jayesh-srivastava commented 2 years ago

I suggest delaying a day or two to get that sorted. We can /hold this merge, get approvals, and then unhold it on publication day (cf https://github.com/kubernetes/contributor-site/issues/281)

@sftim I have updated the date too.

jayesh-srivastava commented 2 years ago

@sftim @jberkus Are there more changes to be made? The date has to be changed tho.

jberkus commented 2 years ago

Jayesh:

There's still to blocks of text that need correction, per above.

jayesh-srivastava commented 2 years ago

@jberkus Have made the changes.

jayesh-srivastava commented 2 years ago

/remove-hold

jayesh-srivastava commented 2 years ago

@jberkus @sftim I guess this can be merged now. I changed the publish date to today's only. Also the hold label needs to be removed. I am not able to do it.

Debanitrkl commented 2 years ago

/remove-hold

jberkus commented 2 years ago

@Debanitrkl @kaslin @sftim we need a date for this, since it'll go on the Kubernetes blog as well.

Debanitrkl commented 2 years ago

I guess next Monday i.e on 11th July let's schedule it.

jayesh-srivastava commented 2 years ago

@Debanitrkl @kaslin @sftim @jberkus Have we decided on the date? Should I change it in the blog?

sftim commented 2 years ago

11th would be fine by me. Is there a PR against https://github.com/kubernetes/website already?

/hold We can remove the hold on the publication date.

jayesh-srivastava commented 2 years ago

@sftim No there isn't a PR for k/website. I'll make it now as we have decided on the date. Also, I've updated the date for this PR.

jayesh-srivastava commented 2 years ago

@sftim This is the PR against k/website. (https://github.com/kubernetes/website/pull/34865)

jayesh-srivastava commented 2 years ago

@sftim @Debanitrkl @jberkus Since there are more reviews on the PR against the k/website which haven't been finalized yet, I think we can hold this PR too until the 18th which is a Monday.

sftim commented 2 years ago

@jayesh-srivastava I'm a reviewer for both blogs; I'm fine with the idea of taking the text from here as the final version. It's nice to incorporate any feedback from SIG Docs' blog team, but not essential.

jayesh-srivastava commented 2 years ago

@sftim I've updated this article as well as the mirror (https://github.com/kubernetes/website/pull/34865) to get published on August 15th. Can you please review them?

sftim commented 2 years ago

/label tide/merge-method-squash /hold until publication date - see https://github.com/kubernetes/contributor-site/issues/281

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Debanitrkl, jayesh-srivastava, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 2 years ago

/hold cancel

Ready to publish