Closed rhockenbury closed 2 years ago
@gracenng @Priyankasaggu11929 @JamesLaverack @cici37 @reylejano - Would appreciate any feedback on this. Thanks.
LGTM. I reviewed the blog post offline.
@rhockenbury, thank you so much for writing it. 🙂
/lgtm Reviewed offline as well
@rhockenbury would you mind trying a new process to make editing of blog posts easier?
Please paste the text of your post into an editable/commentable document -- either GoogleDocs or Hackmd, and place a link in this PR.
We're finding that PRs are pretty bad for copy-editing.
/hold for editing as a document.
Sounds good, I actually have a copy as a Google doc.
Thanks for helping us try out this new process. I've gone through and made some suggestions and comments. All my edits are in the form of suggestions so you know what's been changed.
Thank you @nate-double-u. All those changes looked good, and I've accepted the edits in the Google Doc. If you wouldn't mind, can you take one more look at my response to this comment? I'll update this PR once we have that settled down.
I took a look, and agree with your change there @rhockenbury :)
I took a look, and agree with your change there @rhockenbury :)
Updated this PR with all the edits. Let me know if there's anything else that needs to be taken care of.
@rhockenbury no, we just need to schedule the post.
/assign @jberkus
@rhockenbury I want to double-check with the main blog team to make sure they don't have any edits, if they want it on the main blog.
Sounds great. I did intend to publish on the main blog and I have this PR open to eventually do that (after this one goes through).
Thanks for the review @rolfedh. Updated this PR with all your feedback from the Google doc.
/lgtm Thanks for this @rhockenbury!
one nit but overall looks good to me cc: SIG Release tech lead @jeremyrickard , current and past enhancements leads @Priyankasaggu11929 @salaxander @JamesLaverack @annajung
Thank you for the update /lgtm
@jberkus - I've addressed all feedback so far. Let me know if it's possible to get this post scheduled. Thanks!
Gentle bump. Hoping to get this in ahead of the announcement for release team shadows which will be happening in a few weeks. @jberkus @jeefy @mrbobbytables
/lgtm Thank you again for raising this!
@sftim what are we waiting for on this blog post, if anything?
We need to future-date this (it looks wrong to add a new article that published last month), but otherwise I think we're good to go.
@rhockenbury if you have time, please also locally squash this to 1 commit and force-push. No worries if you're not already used to doing that; if you let us know, we can get Prow & GitHub to do something similar.
/hold cancel
editing done
but:
/hold We need to update the publication date for the article
@sftim - Please take another look. I've addressed your comments.
/lgtm /approve
Thanks @rhockenbury
Maybe now? /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rhockenbury, sftim
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
This PR adds a blog post about the enhancements subteam on the release team.