kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
64 stars 153 forks source link

Blogpost: Add post about enhancements on kubernetes release team #318

Closed rhockenbury closed 2 years ago

rhockenbury commented 2 years ago

This PR adds a blog post about the enhancements subteam on the release team.

rhockenbury commented 2 years ago

@gracenng @Priyankasaggu11929 @JamesLaverack @cici37 @reylejano - Would appreciate any feedback on this. Thanks.

Priyankasaggu11929 commented 2 years ago

LGTM. I reviewed the blog post offline.

@rhockenbury, thank you so much for writing it. 🙂

gracenng commented 2 years ago

/lgtm Reviewed offline as well

jberkus commented 2 years ago

@rhockenbury would you mind trying a new process to make editing of blog posts easier?

Please paste the text of your post into an editable/commentable document -- either GoogleDocs or Hackmd, and place a link in this PR.

We're finding that PRs are pretty bad for copy-editing.

jberkus commented 2 years ago

/hold for editing as a document.

rhockenbury commented 2 years ago

Sounds good, I actually have a copy as a Google doc.

nate-double-u commented 2 years ago

Thanks for helping us try out this new process. I've gone through and made some suggestions and comments. All my edits are in the form of suggestions so you know what's been changed.

rhockenbury commented 2 years ago

Thank you @nate-double-u. All those changes looked good, and I've accepted the edits in the Google Doc. If you wouldn't mind, can you take one more look at my response to this comment? I'll update this PR once we have that settled down.

nate-double-u commented 2 years ago

I took a look, and agree with your change there @rhockenbury :)

rhockenbury commented 2 years ago

I took a look, and agree with your change there @rhockenbury :)

Updated this PR with all the edits. Let me know if there's anything else that needs to be taken care of.

jberkus commented 2 years ago

@rhockenbury no, we just need to schedule the post.

rhockenbury commented 2 years ago

/assign @jberkus

jberkus commented 2 years ago

@rhockenbury I want to double-check with the main blog team to make sure they don't have any edits, if they want it on the main blog.

rhockenbury commented 2 years ago

Sounds great. I did intend to publish on the main blog and I have this PR open to eventually do that (after this one goes through).

rhockenbury commented 2 years ago

Thanks for the review @rolfedh. Updated this PR with all your feedback from the Google doc.

nate-double-u commented 2 years ago

/lgtm Thanks for this @rhockenbury!

reylejano commented 2 years ago

one nit but overall looks good to me cc: SIG Release tech lead @jeremyrickard , current and past enhancements leads @Priyankasaggu11929 @salaxander @JamesLaverack @annajung

reylejano commented 2 years ago

Thank you for the update /lgtm

rhockenbury commented 2 years ago

@jberkus - I've addressed all feedback so far. Let me know if it's possible to get this post scheduled. Thanks!

rhockenbury commented 2 years ago

Gentle bump. Hoping to get this in ahead of the announcement for release team shadows which will be happening in a few weeks. @jberkus @jeefy @mrbobbytables

cici37 commented 2 years ago

/lgtm Thank you again for raising this!

jberkus commented 2 years ago

@sftim what are we waiting for on this blog post, if anything?

sftim commented 2 years ago

We need to future-date this (it looks wrong to add a new article that published last month), but otherwise I think we're good to go.

@rhockenbury if you have time, please also locally squash this to 1 commit and force-push. No worries if you're not already used to doing that; if you let us know, we can get Prow & GitHub to do something similar.

sftim commented 2 years ago

/hold cancel

editing done

sftim commented 2 years ago

but:

/hold We need to update the publication date for the article

rhockenbury commented 2 years ago

@sftim - Please take another look. I've addressed your comments.

sftim commented 2 years ago

/lgtm /approve

Thanks @rhockenbury

sftim commented 2 years ago

Maybe now? /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhockenbury, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 2 years ago

/hold cancel