kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
64 stars 153 forks source link

blog: Fix image rendering #320

Closed mk46 closed 2 years ago

mk46 commented 2 years ago

This PR will fix the broken image in https://www.kubernetes.dev/blog/2022/03/15/k8s-triage-bot-helper-ci-job/ Fixes #305

mk46 commented 2 years ago

Preview: https://deploy-preview-320--kubernetes-contributor.netlify.app/blog/2022/03/15/k8s-triage-bot-helper-ci-job/

mk46 commented 2 years ago

/hold please do not move the images from their location. Hugo can reference files in the same dir as a page resource

Sorry, Hugo is not rendering images from the same dir. Please see https://github.com/kubernetes/contributor-site/pull/293/files#r860838575.

faced a similar issue(https://github.com/kubernetes/website/issues/33204) in k/website too, which was fixed by moving images resources to static dir(https://github.com/kubernetes/website/pull/34918).

mrbobbytables commented 2 years ago

@mk46 here is an example - https://github.com/kubernetes/contributor-site/tree/master/content/en/blog/2020/contributing-to-the-development-guide

there are also other examples outside of the blog dir in the other areas of the site

mk46 commented 2 years ago

should I remove content/en/blog/2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s-ci-bot-make-update-helper.md? PTAL. Thanks!!

mrbobbytables commented 2 years ago

The file should be renamed index.md and that should hopefully solve the issue.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mk46, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [mrbobbytables] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment