kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
67 stars 149 forks source link

Implementing Official CVE Feed alpha #330

Closed PushkarJ closed 2 years ago

PushkarJ commented 2 years ago

Preview: https://deploy-preview-330--kubernetes-contributor.netlify.app/blog/2022/09/12/k8s-cve-feed-alpha/ /sig security docs /area security

related to https://github.com/kubernetes/website/pull/35608 (Need both to be merged together) and https://github.com/kubernetes/enhancements/issues/3203 /hold

k8s-ci-robot commented 2 years ago

@PushkarJ: The label(s) area/security cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes/contributor-site/pull/330): >- Supporting blog to the announcement of the CVE feed >- Covers implementation details, design considerations >- Links to original blog > >/sig security docs >/area security > >related to https://github.com/kubernetes/website/pull/35608 (Need both to be merged together) >/hold Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jberkus commented 2 years ago

Pushkar,

I've created this hackmd file because I wanted to rewrite parts of your blog post for clearer language, and that's easier than giving you a bunch of individual edits: https://hackmd.io/-5mXZZQWQyaTbU45O6AHhQ

jberkus commented 2 years ago

Done editing the Hackmd file. Please review it; I think it improves some of the text around describing your implementation. Particularly, check how I converted passive to active voice in a lot of sentences.

sftim commented 2 years ago

/hold

due to https://github.com/kubernetes/contributor-site/issues/281

PushkarJ commented 2 years ago

@jberkus can you please grant me access to hackmd link you shared?

jberkus commented 2 years ago

Pushkar: it should be public. What are you seeing when you try to access it?

jberkus commented 2 years ago

Aha, never mind, found the problem.

Use the view link if you don't have a hackmd account: https://hackmd.io/-5mXZZQWQyaTbU45O6AHhQ?view

PushkarJ commented 2 years ago

Thanks @jberkus and @sftim for the wonderful input via hackmd. I have updated the PR with the suggested changes!

jberkus commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, PushkarJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
imnmo commented 2 years ago

/hold

due to #281

@sftim could you please check this PR: https://github.com/kubernetes/contributor-site/pull/331 fixing the issue for future blog posts with PublishDate variable

sftim commented 2 years ago

Given that this will merge into main which already has the fix from #331

/hold cancel

:crossed_fingers: