Closed PushkarJ closed 2 years ago
@PushkarJ: The label(s) area/security
cannot be applied, because the repository doesn't have them.
Pushkar,
I've created this hackmd file because I wanted to rewrite parts of your blog post for clearer language, and that's easier than giving you a bunch of individual edits: https://hackmd.io/-5mXZZQWQyaTbU45O6AHhQ
Done editing the Hackmd file. Please review it; I think it improves some of the text around describing your implementation. Particularly, check how I converted passive to active voice in a lot of sentences.
@jberkus can you please grant me access to hackmd link you shared?
Pushkar: it should be public. What are you seeing when you try to access it?
Aha, never mind, found the problem.
Use the view link if you don't have a hackmd account: https://hackmd.io/-5mXZZQWQyaTbU45O6AHhQ?view
Thanks @jberkus and @sftim for the wonderful input via hackmd. I have updated the PR with the suggested changes!
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jberkus, PushkarJ
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold
due to #281
@sftim could you please check this PR: https://github.com/kubernetes/contributor-site/pull/331 fixing the issue for future blog posts with PublishDate variable
Given that this will merge into main which already has the fix from #331
/hold cancel
:crossed_fingers:
Preview: https://deploy-preview-330--kubernetes-contributor.netlify.app/blog/2022/09/12/k8s-cve-feed-alpha/ /sig security docs /area security
related to https://github.com/kubernetes/website/pull/35608 (Need both to be merged together) and https://github.com/kubernetes/enhancements/issues/3203 /hold