kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
67 stars 149 forks source link

Fix articles publishing too early with Front matter config #331

Closed imnmo closed 2 years ago

imnmo commented 2 years ago

This is the PR for issue: https://github.com/kubernetes/contributor-site/issues/281

k8s-ci-robot commented 2 years ago

Welcome @imnmo!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

imnmo commented 2 years ago

@sftim would be really great if you could provide feedback on this

imnmo commented 2 years ago

@sftim could you please check if everything is fine after the preview build for future date blog & provide feedback to proceed further

sftim commented 2 years ago

Thanks /lgtm

If you know how to @imnmo: you are also welcome to squash commits locally and force-push the result. It's also fine if you don't, we can get GitHub to do something broadly similar. /label tide/merge-method-squash

imnmo commented 2 years ago

thanks, @sftim I tried to squash the last two commits -it worked, but I couldn't squash the initial two commits before the rebase happened.

So would request GitHub to squash and merge for me and I will follow the squash before pushing next time.

imnmo commented 2 years ago

Unfortunately, I messed up with my commits & reverts.

I will wait for the GitHub squash method to take into consideration. Kindly help @sftim , sorry for that rookie here.

sftim commented 2 years ago

No worries /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imnmo, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 2 years ago

/lgtm