Closed marquiz closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: marquiz
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval by writing /assign @sftim
in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/hold
Let's make it clear that the KEP itself is in draft. OK to unhold once the article makes that detail clear.
ping @kad @haircommander @SergeyKanzhelev @dchen1107 @mikebrow @mrunalp
Let's make it clear that the KEP itself is in draft. OK to unhold once the article makes that detail clear.
Thanks @sftim for your feedback. I now tried to address this in the latest version, wdyt?
/unhold
I still have several reservations about publishing the article as I see it.
I still have several reservations about publishing the article as I see it.
Could you be more specific about your concerns?
One point I want to emphasize is that this initiative is not vendor specific but aims at implementing a generalized mechanism for supporting new types of QoS controls (or QoS-class resources as they are called here). Even if one of the technologie highlighted is from Intel.
Waiting for comments /hold
Thanks for the feedback @sftim
sigh
I'm certainly not keen to promote that approach through a blog. Instead, folks should get an annotation registered first (having made sure it fits the Kubernetes project's views on IT architecture), and then add that definition into to a Kubernetes code package for other codebases to import.
Co-ordination is important. What Intel and CRI-O has done here has happened; we should try to help them replace it with something official, and we definitely shouldn't make it look like we (Kubernetes project) endorse it.
Yeah, in retrospect the selection of the annotation name was an unfortunate and ill-advised choice. One reason for that was that we wanted to have the same annotation for both cri-o and containerd but could've chosen more wisely. But it's there now and can be dropped in the future.
Anyway, after thinking about the blog post I now agree with you that it's better not to promote features / KEPs that are not yet at least accepted for Kubernetes. I'll now change this PR into draft state. I'll update this PR and remove draft state when / if the KEP gets accepted and initial support (code) gets merged to k/k.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
This is still relevant. Waiting for the KEP to get merged (now targeting v1.27) /remove-lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Still waiting for the KEP to be merged /remove-lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
I'm still working on the KEP so this is valid, too /remove-lifecycle rotten
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@marquiz is this work still relevant and something you're continuing to work on? thanks for your previous updates
Thanks @natalisucks. Yes, this is still relevant but pending https://github.com/kubernetes/enhancements/pull/3004
If this is too much burden/hassle we can close this PR be closed and I can re-open when topical
/remove-lifecycle stale
no problem @marquiz – i see the KEP is being tracked for 1.30, so i'm fine with you keeping this open and coming back once the KEP goes through with this release. i'd also recommend that if it doesn't for 1.30, feel free to close and re-open whenever you'd like to come back to this work. cheers!
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
Create a blog post for introducing the QoS-class resources KEP.
This is a re-submission of a PR to kubernetes.io blog (https://github.com/kubernetes/website/pull/34880) where it was suggested to post in k8s dev blog, instead.