kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
67 stars 149 forks source link

blog: add Qos-class resources blog post #332

Closed marquiz closed 2 months ago

marquiz commented 2 years ago

Create a blog post for introducing the QoS-class resources KEP.

This is a re-submission of a PR to kubernetes.io blog (https://github.com/kubernetes/website/pull/34880) where it was suggested to post in k8s dev blog, instead.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marquiz Once this PR has been reviewed and has the lgtm label, please assign sftim for approval by writing /assign @sftim in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 2 years ago

/hold

Let's make it clear that the KEP itself is in draft. OK to unhold once the article makes that detail clear.

marquiz commented 2 years ago

ping @kad @haircommander @SergeyKanzhelev @dchen1107 @mikebrow @mrunalp

marquiz commented 2 years ago

Let's make it clear that the KEP itself is in draft. OK to unhold once the article makes that detail clear.

Thanks @sftim for your feedback. I now tried to address this in the latest version, wdyt?

sftim commented 2 years ago

/unhold

I still have several reservations about publishing the article as I see it.

marquiz commented 2 years ago

I still have several reservations about publishing the article as I see it.

Could you be more specific about your concerns?

One point I want to emphasize is that this initiative is not vendor specific but aims at implementing a generalized mechanism for supporting new types of QoS controls (or QoS-class resources as they are called here). Even if one of the technologie highlighted is from Intel.

marquiz commented 2 years ago

Waiting for comments /hold

marquiz commented 2 years ago

Thanks for the feedback @sftim

sigh

I'm certainly not keen to promote that approach through a blog. Instead, folks should get an annotation registered first (having made sure it fits the Kubernetes project's views on IT architecture), and then add that definition into to a Kubernetes code package for other codebases to import.

Co-ordination is important. What Intel and CRI-O has done here has happened; we should try to help them replace it with something official, and we definitely shouldn't make it look like we (Kubernetes project) endorse it.

Yeah, in retrospect the selection of the annotation name was an unfortunate and ill-advised choice. One reason for that was that we wanted to have the same annotation for both cri-o and containerd but could've chosen more wisely. But it's there now and can be dropped in the future.

Anyway, after thinking about the blog post I now agree with you that it's better not to promote features / KEPs that are not yet at least accepted for Kubernetes. I'll now change this PR into draft state. I'll update this PR and remove draft state when / if the KEP gets accepted and initial support (code) gets merged to k/k.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

marquiz commented 1 year ago

This is still relevant. Waiting for the KEP to get merged (now targeting v1.27) /remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

marquiz commented 1 year ago

Still waiting for the KEP to be merged /remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

marquiz commented 1 year ago

I'm still working on the KEP so this is valid, too /remove-lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

natalisucks commented 7 months ago

@marquiz is this work still relevant and something you're continuing to work on? thanks for your previous updates

marquiz commented 7 months ago

Thanks @natalisucks. Yes, this is still relevant but pending https://github.com/kubernetes/enhancements/pull/3004

If this is too much burden/hassle we can close this PR be closed and I can re-open when topical

natalisucks commented 7 months ago

/remove-lifecycle stale

no problem @marquiz – i see the KEP is being tracked for 1.30, so i'm fine with you keeping this open and coming back once the KEP goes through with this release. i'd also recommend that if it doesn't for 1.30, feel free to close and re-open whenever you'd like to come back to this work. cheers!

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 months ago

@k8s-triage-robot: Closed this PR.

In response to [this](https://github.com/kubernetes/contributor-site/pull/332#issuecomment-2215180604): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the PR is closed > >You can: >- Reopen this PR with `/reopen` >- Mark this PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.