kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
67 stars 149 forks source link

Ensure that analytics is disabled for non-production builds #357

Open chalin opened 1 year ago

chalin commented 1 year ago

If you look at the page source of a preview build like https://deploy-preview-347--kubernetes-contributor.netlify.app/, you'll see that analytics are enabled. We only want analytics for the main site.

The source of the problem is this config: https://github.com/kubernetes/contributor-site/blob/1a8d9c6dff430129d1ab6998b539f8367aa9171e/netlify.toml#L5-L7

We don't want to specify all builds as being "production" builds (HUGO_ENV).

chalin commented 1 year ago

Note that once the following issues are closed, this issue should be resolved as well (though it can be resolved independently too):

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

chalin commented 1 year ago

/remove-lifecycle stale

sftim commented 1 year ago

/priority important-longterm

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten