search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
67 stars 149 forks source link

Upgrade Hugo and Docsy #360

Closed chalin closed 3 months ago

chalin commented 1 year ago

The versions of Hugo and Docsy are quite old.

https://github.com/kubernetes/contributor-site/blob/1a8d9c6dff430129d1ab6998b539f8367aa9171e/netlify.toml#L5-L6

For example, Hugo 0.69.2 was released in April 2020.

/cc @nate-double-u

chalin commented 1 year ago

Why upgrade? E.g., Docsy's current page-feedback feature is incompatible with GA4 (https://github.com/google/docsy/issues/1302). Since UA is being deprecated and this site is being migrated to GA4 (#354), the a new version of Docsy will eventually be needed. (There is a work-around for the page-feedback issue, so the upgrade isn't urgent.)

jberkus commented 1 year ago

Is this something you can help with?

sftim commented 1 year ago

I agree that it's useful to upgrade.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jberkus commented 1 year ago

/remove-lifecycle stale

We were able to upgrade to 0.89, but remain stalled on the upgrade to 110.

sftim commented 1 year ago

See the revised PR, #374

chris-short commented 10 months ago

We did spend some time on this during the Contributor Summit at KubeCon Chicago. @jeefy's fork has some errors we need to work through but, we've made a step forward here.

sftim commented 10 months ago

What still needs to happen before we can call this Done?

jeefy commented 10 months ago

I'm back and working through said errors (actually I started from scratch and scrapped my post-lunch hastily-done branch)

Most errors that we encountered at the summit are fixed, and the last thing I'm updating is the Dockerfile. PR inc soon.

jeefy commented 10 months ago

Oh duh.

/assign

chris-short commented 10 months ago

Were you going to tackle the move from submodules to Hugo Modules? I can do that separately if you'd like.

I also want to update the K8s.dev picture now that we have a big crowd pic for a replacement.

jeefy commented 10 months ago

Kinda did it all, see here: https://github.com/kubernetes/contributor-site/pull/456

Need help with a CSS issue post-migration but otherwise it's all done and clean.

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

jberkus commented 6 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

stmcginnis commented 3 months ago

/remove-lifecycle stale

stmcginnis commented 3 months ago

Looks like we're up to Hugo 0.124 now. There is a slightly newer release out, but I think it's just regular dependency management at this point. Follow-on work being done in #456. I think it's safe to close this issue now.

/close

k8s-ci-robot commented 3 months ago

@stmcginnis: Closing this issue.

In response to [this](https://github.com/kubernetes/contributor-site/issues/360#issuecomment-2159257325): >Looks like we're up to [Hugo 0.124 now](https://github.com/kubernetes/contributor-site/blob/c9d1a78cbed3609a0db62f410d7bc33d36cbce07/netlify.toml#L6). There is a slightly newer release out, but I think it's just regular dependency management at this point. Follow-on work being done in #456. I think it's safe to close this issue now. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.