Closed sftim closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sftim
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold This does break the site a bit - take a look at the side menu on the preview vs the actual site: https://deploy-preview-374--kubernetes-contributor.netlify.app/docs/ https://kubernetes.dev/docs/
@sftim so the issue is the preview rather than the Hugo version?
I think there is a real problem here; it's harder to see what that is because my local preview is - right now - missing the generated content either way.
We shouldn't merge this change as-is.
PR https://github.com/kubernetes/contributor-site/pull/375 may help us to find a newer Hugo version that nonetheless works OK, and that find may then help us spot what to change so that we can upgrade further.
We can work around the Hugo problem by setting GOMAXPROCS
to 1
I think this is good to unhold - check the site, it looks right with the latest fixes.
We can remove those once a separate PR updates Docsy.
This seems fine. Clicked around the preview a bunch and it looks good.
/lgtm
Thanks
/hold cancel
FWIW I've compared things side-by-side and didn't find any different, looks good.
Bump Hugo version to ~0.110~ 0.112 (preview).
There is build-time warning:
Also, update local preview using a container image (copy approach from k/website
Makefile
). The container image now mounts this Git repo read-only.Helps with https://github.com/kubernetes/contributor-site/issues/360