kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
66 stars 148 forks source link

Generate content even for container preview #375

Closed sftim closed 10 months ago

sftim commented 1 year ago

This change makes sure that generated content is up to date when previewing locally in a container.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 1 year ago

I'm going to use this as a basis for my work on #374 (whether we merge it or not).

sftim commented 1 year ago

:thought_balloon: do we always want this behavior, or (eg) only when a particular variable is set?

jberkus commented 1 year ago

What's the status of this PR? It doesn't sound like you're ready with it.

sftim commented 1 year ago

This works for me @jberkus

I don't know whether it's useful for other contributors, and I can't easily answer that question.

~I'll rebase it~ I rebased it against master

jberkus commented 10 months ago

/lgtm