kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
66 stars 148 forks source link

Drop Google Universal Analytics (UA) ID #376

Closed chalin closed 1 year ago

chalin commented 1 year ago
k8s-ci-robot commented 1 year ago

Welcome @chalin!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

jberkus commented 1 year ago

Just checking, this works even without the Hugo upgrade?

chalin commented 1 year ago

Just checking, this works even without the Hugo upgrade?

Right. No upgrade necessary since the GA4 ID is being set via Netlify snippet injection -- see. #354.

jberkus commented 1 year ago

/approve

need an LGTM from another contributor ... @jeefy ?

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chalin, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chris-short commented 1 year ago

/lgtm