search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
66 stars 148 forks source link

Add blog post for scheduler plugin reusing #381

Closed uniemimu closed 6 months ago

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: uniemimu Once this PR has been reviewed and has the lgtm label, please assign mrbobbytables for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

Welcome @uniemimu!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

jberkus commented 1 year ago

Apolgies! Somehow this PR never showed up in my notifications, and as such I just noticed it. Thank you so much for your patience. I will review it during/after Kubecon and move it forwards.

jberkus commented 1 year ago

This passes spelling and composition check, but I'm waiting for @kubernetes/sig-scheduling-misc review; I've reached out to the SIG.

alculquicondor commented 1 year ago

/assign @Huang-Wei

jberkus commented 1 year ago

OK, this looks good, should we publish?

Huang-Wei commented 1 year ago

OK, this looks good, should we publish?

Yup, /lgtm on scheduling side.

uniemimu commented 1 year ago

Should I squash this?

jberkus commented 1 year ago

You can if you want. I can also have Tide do it.

However, I need to confer with @sftim on how we fix the date for the blog post.

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

natalisucks commented 6 months ago

@uniemimu do you have capacity to address Tim's feedback?

uniemimu commented 6 months ago

@uniemimu do you have capacity to address Tim's feedback?

Obviously I haven't had, my apologies for that. Since the somewhat related KEP PR (3925) never found any interest, I'm leaning towards closing this PR without publishing. What do you think?

natalisucks commented 6 months ago

@uniemimu I think that's completely fine. If the KEP picks up traction again, this PR can always be re-opened and worked on once again. Thanks for answering!