Closed pohly closed 1 year ago
It would be great to get this published before KubeCon EU 2023 because then readers have the opportunity to ask questions on-site in person.
@aojea: The intro, the architecture and the "next steps" are new. The rest is text that you already reviewed earlier for https://github.com/kubernetes/community/pull/7021, just updated a bit to make it flow better in a blog post.
/assign @mrbobbytables
For approval. Let's get this published before KubeCon, then folks can chat with me about it there.
LGTM overall good summary of the work done and the expectations for e2e tests, it will be good to promote this blog for reviewers of the different SIGs , so we can have consistency on all the e2e tests.
I left some comments that are not blockers and if necessary can be follow ups
/assign @sftim
you need docs people IIRC for approval
/hold
I'll follow up on some of the suggestions before this gets merged.
/hold cancel
PR updated, ready for another LGTM and approval.
BTW, approval is SIG ContribEx blog team.
/lgtm
Thanks
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mrbobbytables, pohly, xmcqueen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
"Writing good E2E tests" was already updated a while ago in https://github.com/kubernetes/community/pull/7021. As suggested there (https://github.com/kubernetes/community/pull/7021#issuecomment-1374333094), we should bring this update to the attention of more contributors, hence this blog post.
/cc @aojea @jberkus