search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
66 stars 148 forks source link

Add SIG CLI Spotlight blog article #411

Closed fsmunoz closed 1 year ago

fsmunoz commented 1 year ago

SIG CLI Spotlight article.

fsmunoz commented 1 year ago

Please review and confirm, especially because while editing I've added some small changes like the links to the GitHub profiles, maybe you prefer to link to Twitter or somewhere else.

/cc @KnVerey @soltysh

fsmunoz commented 1 year ago

/cc @arpitjindal97

k8s-ci-robot commented 1 year ago

@fsmunoz: GitHub didn't allow me to request PR reviews from the following users: arpitjindal97.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes/contributor-site/pull/411#issuecomment-1627706986): >/cc @arpitjindal97 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
arpitjindal97 commented 1 year ago

You guys tagged wrong Arpit 😆

fsmunoz commented 1 year ago

@arpitjindal97 apologies, will correct the commit, thanks for the heads-up!

fsmunoz commented 1 year ago

/uncc @arpitjindal97

sftim commented 1 year ago

It would be nice to have a PR against k/website ready so that we mirror this article there (with this one as canonical)

See other articles in this series for hints about how we've done that.

sftim commented 1 year ago

/retitle Add SIG CLI Spotlight blog article

fsmunoz commented 1 year ago

@sftim sure, added https://github.com/kubernetes/website/pull/41973 for the website.

fsmunoz commented 1 year ago

Going to change the publishing date header if no updates during the day .

sftim commented 1 year ago

I expected that https://github.com/kubernetes/website/pull/41973/ would be filled in a lot more. I'd prefer to wait until both are ready to go.

/hold

How about bumping these both back 7 days, and filling in https://github.com/kubernetes/website/pull/41973/ so that it previews OK? Have a look at other SIG spotlight article PRs in k/website to see how this is done.

OK to unhold once the other PR is reviewable.

fsmunoz commented 1 year ago

Hi @sftim, thanks for the comments. I kept it empty on purpose, for two reasons:

I can easily push a commit to the other one right now, with the existing content, and changing the publishing date as suggested. We should then better document the process (I can update the blogging guidelines we have in Comms).

sftim commented 1 year ago

I can easily push a commit to the other one right now, with the existing content, and changing the publishing date as suggested. We should then better document the process (I can update the blogging guidelines we have in Comms).

Cool, let's do that.

fsmunoz commented 1 year ago

Changed date, rebased, updated https://github.com/kubernetes/website/pull/41973 with existing content, as discussed!

sftim commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 1 year ago

/hold cancel