Add Spotlight Blog for SIG Release - Release Team Subproject

nitishfy commented 10 months ago

Spotlight blog for the SIG-Release - Release Team Subproject.

nitishfy commented 10 months ago

Update: Ready for the next set of review.

fsmunoz commented 10 months ago

Update: Ready for the next set of review.

There are still some unresolved suggestions. Some are open to further debate, others are about clerical errors (like the one pointed out by @sftim above) which are more straightforward - so much so that if you agree with the changes, it would be simpler in the future to accept the suggestions on GitHub since that provides an easier way to track them (not now, since they were marked out of date), and would've resolved this particular one - additionally, it updates the commit authors with those reviewing, something which is also possible when you do the final squash but doing it "by hand" is harder.

Apart from that, the images are a nice touch and I think the interview is quite interesting, so I think that with the open points resolved this is good to go, great work!

fsmunoz commented 10 months ago

@nitishfy , I have added suggestions, one of them is due to new content, the other is to address the spelling of one word (already discussed). Please go through the open comments, there's one on the need for 100 char limit as well. All discussion points should be resolved (not necessarily changed). We're getting there though!

nitishfy commented 10 months ago

@nitishfy , I have added suggestions, one of them is due to new content, the other is to address the spelling of one word (already discussed). Please go through the open comments, there's one on the need for 100 char limit as well. All discussion points should be resolved (not necessarily changed). We're getting there though!

I'm afraid why doesn't the preview show this blog? :(

sftim commented 9 months ago

I'm afraid why doesn't the preview show this blog? :(

Does this preview OK locally? (run make container-server and then visit http://localhost:1313/blog/ to see the preview)

nitishfy commented 9 months ago

Not sure why the changes are not getting reflected. cc: @fsmunoz @sftim

nitishfy commented 9 months ago

Ready for the next set of reviews.

nitishfy commented 7 months ago

This PR is ready for the next set of reviews, here are a few points that I'd like to mention:

Netlify was not showing the preview initially because we had not used the date format in our blog earlier. It was TBD than a date format. I've currently set a random date so that the preview can be available, we can modify this later.
I've gone through the markdown wrapping suggestion above and have wrapped the lines. Please note that the wrapping of lines is not completely aligned with what @aj11anuj has suggested. I've used my own approach to wrap the lines but I think this works in both cases.
Also, @sftim suggested a change in the text of the diagram. The diagram was created with the help of Excalidraw and no longer exists locally. I'm afraid we might not be able to alter the text in the diagram.

cc: @fsmunoz

fsmunoz commented 7 months ago

@nitishfy thank you for taking care of the comments. IMO, wrapping at 100 is a guideline that when followed strictly can result in requests for change (e.g., when it breaks the markdown link syntax in different lines), so as long as the general idea of wrapping it for facilitate reviews is adopted, I don't think there is a rigid requirement for keeping everything at exactly 100. I would mark that one resolved as well.

sftim commented 6 months ago

Once the comments from https://github.com/kubernetes/contributor-site/pull/424#pullrequestreview-1774138786 are fixed, I'll get a mirror PR opened against the main Kubernetes blog.

nitishfy commented 6 months ago

Once the comments from #424 (review) are fixed, I'll get a mirror PR opened against the main Kubernetes blog.

we already have an ordered list in the form of questions.

sftim commented 6 months ago

we already have an ordered list in the form of questions.

Sorry, I may be missing something. That sentence doesn't make any sense to me in the context.

Can you explain what you mean @nitishfy ?

nitishfy commented 6 months ago

we already have an ordered list in the form of questions.

Sorry, I may be missing something. That sentence doesn't make any sense to me in the context.

Can you explain what you mean @nitishfy ?

Could you explain what you mean here to number sections? If we are mentioning about numbering the questions that have been asked, it has already been marked.

nitishfy commented 6 months ago

Squashed the commits.

nitishfy commented 6 months ago

I think we're ready to merge this PR now

sftim commented 6 months ago

Thanks for the PR.

/lgtm /approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitishfy, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sftim commented 6 months ago

/hold cancel

nitishfy commented 6 months ago

FYI, we need to add a PR under k/website as well, correct?

fsmunoz commented 6 months ago

FYI, we need to add a PR under k/website as well, correct?

Yes, with the reviewed content, and the small changes needed (mainly header tags and the author indication).

kubernetes / contributor-site

Add Spotlight Blog for SIG Release - Release Team Subproject #424