kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
63 stars 147 forks source link

Remove stale text about documentation being available in English #428

Closed aj11anuj closed 2 months ago

aj11anuj commented 10 months ago

What's the need to write that line "You're lucky, that documents are available in English" in any other language other than English and later at bottom translating it to English in small letters.

Most of the people who are reading this docs/course are English readers and a very few people who know that language will only be able to grasp that line.

And if someone is viewing this course/docs in mobile, than that line at bottom in small letters is not noticable at first sight. When i saw this slide in first sight then i used Google Translate to translate that line and later i noticed it's translation is written in smaller letters at bottom. I think it will be better to simply write that line in English only, and keep docs as precise as possible.

Page to update: https://www.kubernetes.dev/docs/onboarding/09-documentation/

k8s-ci-robot commented 10 months ago

Welcome @aj11anuj!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

mrbobbytables commented 10 months ago

Honestly - I'd just remove the statement altogether. I don't think it would have made it through initial review had it been known what it stated

jberkus commented 9 months ago

Yeah, this is a joke about the word Kubernetes being Greek. It was a fine joke for a presentation, but it doesn't work as docs.

sftim commented 8 months ago

/retitle Remove stale text about documentation being available in English

sftim commented 8 months ago

@aj11anuj please edit the issue description to tell people that you're commenting on https://www.kubernetes.dev/docs/onboarding/09-documentation/

It's otherwise really not obvious.

sftim commented 6 months ago

Please see https://github.com/kubernetes/contributor-site/pull/428#issuecomment-1704271344

Best to drop the line altogether, Greek and English.

jberkus commented 2 months ago

/approve /lgtm

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aj11anuj, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment