search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
67 stars 152 forks source link

Change of "Twitter" icon to "X" icon at footer #439

Closed aj11anuj closed 1 year ago

aj11anuj commented 1 year ago

This is a Feature Request

What would you like to be added/enhanced? As everybody knows, Twitter is now under X corp. and its world famous blue bird icon has been changed to "X" icon a long time ago. So, maybe we should update it here in footer too.

Why is this needed? I know everyone likes that blue twitter icon, and twitter is better recognised with that icon. But as company has been renamed to "X" with "X" icon then shouldn't we update it?

aj11anuj commented 1 year ago

/kind feature /sig docs /area web-development

k8s-ci-robot commented 1 year ago

@aj11anuj: The label(s) area/web-development cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes/contributor-site/issues/439#issuecomment-1735191756): >/kind feature >/sig docs >/area web-development Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mrbobbytables commented 1 year ago

We inherit it from the theme. When it changes and we upgrade, ours will change. There's no need to modify our current site to do such a small change. Especially with most major sites still using the bird.

/close