search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
67 stars 152 forks source link

Add SIG Testing Spotlight article #454

Closed fsmunoz closed 10 months ago

fsmunoz commented 11 months ago

Add SIG Testing spotlight article

Closes: #413

fsmunoz commented 11 months ago

/cc @sandipanpanda

fsmunoz commented 10 months ago

/retitle Add SIG Testing Spotlight article

sftim commented 10 months ago

https://github.com/kubernetes/contributor-site/pull/454#discussion_r1398185584 is the one thing I would like to see changed; the other feedback is optional.

sftim commented 10 months ago

/hold

Once https://github.com/kubernetes/website/pull/43982 is approved, it's OK to unhold this. If it turned out that https://github.com/kubernetes/website/pull/43982 didn't get reviewed in time (there's little reviewer capacity), it's also OK to skip the mirroring and unhold to publish just this article.

This article will merge first and then once this merges, someone can unhold https://github.com/kubernetes/website/pull/43982

fsmunoz commented 10 months ago

Thank you @sftim , I added all your suggestions and squashed, and will update 43982 as well.

fsmunoz commented 10 months ago

Both this one and the one on website are on hold waiting for the other; to break the loop, I'll unhold this one first.

/unhold

sftim commented 10 months ago

/hold

We should get both articles approved before unholding. See https://github.com/kubernetes/contributor-site/pull/454#issuecomment-1817473130 for more details.

sftim commented 10 months ago

If this gets LGTM and approval, and the deadline arrives, then it's OK to unhold. I'll take a look at both articles.

sftim commented 10 months ago

/lgtm /approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 10 months ago

@fsmunoz https://github.com/kubernetes/website/pull/43982 is marked as a work in progress. Is that intentional?

fsmunoz commented 10 months ago

@sftim fixed there, thanks!

sftim commented 10 months ago

/hold cancel https://github.com/kubernetes/website/pull/43982 is approved and LGTM