Closed fsmunoz closed 4 months ago
@nimbinatus thanks for the review. You've suggested a set of changes to the words that the interviewers spoke; we usually wouldn't make that kind of edit.
@sftim my apologies; I may have misunderstood a thread in the contributor comms slack channel when I asked if edits are requested along with a proofread and tech check. I'll drop the ones that change words.
Edit: I updated my review with responses. Please feel free to accept or reject changes, and I'll do the approvals after they're either accepted or rejected.
@nimbinatus yes that was me in Slack, I guess we thought slightly different things when style was mentioned (my fault for not being clear though). I was referring to the review being open for editing and corrections if there were sentences that were clearly hard to understand, misspelt, or lacked coherence in terms of English variant, and not just in terms of Markdown structure or technical content.
I do agree with many of your suggestions (in that they don't change the intended meaning), but as @sftim mentioned, we tend to err on the side of avoiding changing the words of the intervenients. This is more a matter of degree than principle, but also because, style-wise, people have different preferences.
I'll incorporate things in a first round and we can discuss the others.
@nimbinatus yes that was me in Slack, I guess we thought slightly different things when style was mentioned (my fault for not being clear though). I was referring to the review being open for editing and corrections if there were sentences that were clearly hard to understand, misspelt, or lacked coherence in terms of English variant, and not just in terms of Markdown structure or technical content.
I do agree with many of your suggestions (in that they don't change the intended meaning), but as @sftim mentioned, we tend to err on the side of avoiding changing the words of the intervenients. This is more a matter of degree than principle, but also because, style-wise, people have different preferences.
I'll incorporate things in a first round and we can discuss the others.
Like I said, just a misunderstanding :) No harm, no foul. I'll know for the future.
Like I said, just a misunderstanding :) No harm, no foul. I'll know for the future.
I wouldn't even go that far, since 80%+ of your suggestions are in, so it's already been very useful. Some of the rest are in areas where we likely should have clearer standards (at least, written ones).
@nimbinatus @sftim I incorporated a lot of the suggested reviews, did some small changes as per the discussion, and kept others as-is. I think we have just one left, will pick it up tomorrow.
I suggest:
Can we bump the publication date (for both articles) back to the 1st of March though?
@sftim on it as we speak :)
Can we bump the publication date (for both articles) back to the 1st of March though?
Yes, will do that. I'm also solving some git issues right now, but will change that.
@sftim done!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fsmunoz, nimbinatus
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hm. I thought the approve slash command was required for the merge, not the approve through GitHub 🤔
Waiting to be sure @sftim is good
/hold
GitHub approve counts as approval @nimbinatus
/hold cancel (may as well)
GitHub approve counts as approval @nimbinatus
Bugger. Sorry about that.
New SIG Spotlight article on SIG Cloud Provider.
Closes: #476