kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
63 stars 147 forks source link

Add SIG Cloud Provider spotlight article. #477

Closed fsmunoz closed 4 months ago

fsmunoz commented 4 months ago

New SIG Spotlight article on SIG Cloud Provider.

Closes: #476

nimbinatus commented 4 months ago

@nimbinatus thanks for the review. You've suggested a set of changes to the words that the interviewers spoke; we usually wouldn't make that kind of edit.

@sftim my apologies; I may have misunderstood a thread in the contributor comms slack channel when I asked if edits are requested along with a proofread and tech check. I'll drop the ones that change words.

Edit: I updated my review with responses. Please feel free to accept or reject changes, and I'll do the approvals after they're either accepted or rejected.

fsmunoz commented 4 months ago

@nimbinatus yes that was me in Slack, I guess we thought slightly different things when style was mentioned (my fault for not being clear though). I was referring to the review being open for editing and corrections if there were sentences that were clearly hard to understand, misspelt, or lacked coherence in terms of English variant, and not just in terms of Markdown structure or technical content.

I do agree with many of your suggestions (in that they don't change the intended meaning), but as @sftim mentioned, we tend to err on the side of avoiding changing the words of the intervenients. This is more a matter of degree than principle, but also because, style-wise, people have different preferences.

I'll incorporate things in a first round and we can discuss the others.

nimbinatus commented 4 months ago

@nimbinatus yes that was me in Slack, I guess we thought slightly different things when style was mentioned (my fault for not being clear though). I was referring to the review being open for editing and corrections if there were sentences that were clearly hard to understand, misspelt, or lacked coherence in terms of English variant, and not just in terms of Markdown structure or technical content.

I do agree with many of your suggestions (in that they don't change the intended meaning), but as @sftim mentioned, we tend to err on the side of avoiding changing the words of the intervenients. This is more a matter of degree than principle, but also because, style-wise, people have different preferences.

I'll incorporate things in a first round and we can discuss the others.

Like I said, just a misunderstanding :) No harm, no foul. I'll know for the future.

fsmunoz commented 4 months ago

Like I said, just a misunderstanding :) No harm, no foul. I'll know for the future.

I wouldn't even go that far, since 80%+ of your suggestions are in, so it's already been very useful. Some of the rest are in areas where we likely should have clearer standards (at least, written ones).

fsmunoz commented 4 months ago

@nimbinatus @sftim I incorporated a lot of the suggested reviews, did some small changes as per the discussion, and kept others as-is. I think we have just one left, will pick it up tomorrow.

sftim commented 4 months ago

I suggest:

sftim commented 4 months ago

Can we bump the publication date (for both articles) back to the 1st of March though?

fsmunoz commented 4 months ago

@sftim on it as we speak :)

fsmunoz commented 4 months ago

Can we bump the publication date (for both articles) back to the 1st of March though?

Yes, will do that. I'm also solving some git issues right now, but will change that.

fsmunoz commented 4 months ago

@sftim done!

nimbinatus commented 4 months ago

/lgtm

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, nimbinatus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [nimbinatus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nimbinatus commented 4 months ago

Hm. I thought the approve slash command was required for the merge, not the approve through GitHub 🤔

nimbinatus commented 4 months ago

Waiting to be sure @sftim is good

/hold

sftim commented 4 months ago

GitHub approve counts as approval @nimbinatus

sftim commented 4 months ago

/hold cancel (may as well)

nimbinatus commented 4 months ago

GitHub approve counts as approval @nimbinatus

Bugger. Sorry about that.