search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
63 stars 147 forks source link

Add SIG Architecture Code Organization spotlight article #493

Closed fsmunoz closed 2 months ago

fsmunoz commented 3 months ago

SIG Architecture: Code Organization spotlight article.

Closes: #482

fsmunoz commented 3 months ago

/cc @MadhavJivrajani

nimbinatus commented 3 months ago

/lgtm

fsmunoz commented 2 months ago

@nimbinatus @sftim I think this is good to go, I've reflected all suggestions, updated the publication date for the suggested one, and squashed it in case it really is the final version. I'm updating https://github.com/kubernetes/website/pull/45725 based on this version and removing the WIP tag.

nimbinatus commented 2 months ago

/lgtm

fsmunoz commented 2 months ago

/unhold (publication date updated)

sftim commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 2 months ago

@dims want to send in a PR to do a fixup here too?

(wrt https://github.com/kubernetes/website/pull/45853)

dims commented 2 months ago

may i defer to @fsmunoz please?

fsmunoz commented 2 months ago

@dims thanks for the fix, I can add it here if it helps, sure. Will open a new PR.