search

kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
63 stars 147 forks source link

Contribute as SIG Docs reviewer blog post #496

Closed ricardoamaro closed 1 month ago

ricardoamaro commented 2 months ago

This blog post aims to attract open-source contributors with Git/GitHub knowledge to become Kubernetes SIG Docs reviewers.

cc/ @sftim Moved from https://github.com/kubernetes/website/pull/46054 as suggested by @dipesh-rawat @reylejano

k8s-ci-robot commented 2 months ago

Welcome @ricardoamaro!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

stmcginnis commented 2 months ago

/lgtm

sftim commented 2 months ago

@stmcginnis as this has a publication date in the past, and we want to merge things with a publication date in the future:

/lgtm cancel

sftim commented 2 months ago

/hold

OK to unhold when both are covered

ricardoamaro commented 2 months ago

Addressed all the feedback and have set a date. Thank you for all the reviews!

jberkus commented 2 months ago

I want to call a halt on this. It's seriously problematic to publish a "contributor journey" for a contributor who doesn't really exist, especially a non-code contributor with a female name. This blog post, as written, violates our code of conduct. It needs to be substantially revised.

Solutions:

Acceptable: delete the whole fictional character journey.

Good: replace the whole fictional character narrative with a much shorter "achievement journey" in 2nd person aimed at the reader.

Better: find an actual SIG-Docs reviewer and write up their journey.

sftim commented 2 months ago

/hold

https://github.com/kubernetes/contributor-site/pull/496#issuecomment-2088955640

ricardoamaro commented 2 months ago

@jberkus Thank you for your feedback. I greatly appreciate your insights, and based on your guidance, I am replacing the fictional narrative with a shorter, more inclusive "achievement journey" aimed directly at the reader. Thank you for pointing this out, and I appreciate the opportunity to adjust and improve.

jberkus commented 2 months ago

@ricardoamaro Yes! That's much better. And it uses a lot of your colorful text.

/lgtm /remove-hold

sftim commented 2 months ago

/hold

Still needs a confirmed publication date.

ricardoamaro commented 1 month ago

@sftim Do we keep the same date?

chris-short commented 1 month ago

/lgtm
/approve

chris-short commented 1 month ago

/remove-hold

jberkus commented 1 month ago

/approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chris-short, jberkus, ricardoamaro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment