kubernetes / contributor-site

Code for kubernetes.dev
https://www.kubernetes.dev
Apache License 2.0
63 stars 147 forks source link

Add SIG Node spotlight interview #498

Closed fsmunoz closed 3 weeks ago

fsmunoz commented 2 months ago

Add SIG Node Spotlight interview.

Closes: #497

fsmunoz commented 1 month ago

@nimbinatus thank you for the review, I already accepted most of them, leaving the ones that require another pass (will address them now)

fsmunoz commented 1 month ago

I've reflected most (if not all) of the contributions, thank you all! I've also changed the publication date as suggested.

sftim commented 1 month ago

Is there a PR to mirror this onto https://blog.k8s.io/ (I'd like there to be)

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

fsmunoz commented 1 month ago

Is there a PR to mirror this onto https://blog.k8s.io/ (I'd like there to be)

Opened it here: https://github.com/kubernetes/website/pull/46454

fsmunoz commented 1 month ago

/check-cla

sftim commented 1 month ago

/check-cla

echoing https://github.com/kubernetes/website/pull/46454#issuecomment-2123419126

sftim commented 1 month ago

/easycla

sftim commented 1 month ago

/hold

pending CLA issues being cleared on this and for https://github.com/kubernetes/website/pull/46454

Also, don't remove the hold if the listed publication date is in the past

sftim commented 1 month ago

@fsmunoz, this may have been affected by recent updates to EasyCLA.

fsmunoz commented 1 month ago

@sftim apparently so since I've already sign the CLA 4 times in different repositories, and it works, but then changes back. I'll do it once more though.

I'll change the publication date to the 28th, is this OK?

fsmunoz commented 1 month ago

@sftim validated with the author that this was a typo and the cgroug v1 was the intended version, as spotted by you.

SergeyKanzhelev commented 1 month ago

/assign @SergeyKanzhelev @matthyx @gjkim42

sftim commented 1 month ago

@kubernetes/sig-contributor-experience-pr-reviews this is ready for a review

kaslin commented 1 month ago

Mine isn't a critical review, but it looks good to me! /lgtm

sftim commented 1 month ago

@fsmunoz if you're minded to squash this down to 1 commit: even better.

fsmunoz commented 1 month ago

@fsmunoz if you're minded to squash this down to 1 commit: even better.

Certainly; I will update the date and squash. Thanks!

sftim commented 3 weeks ago

LGTM from https://github.com/kubernetes/contributor-site/pull/498#issuecomment-2143012880 should stand.

/lgtm /approve

Please don't unhold yet.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/contributor-site/blob/master/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 3 weeks ago

/hold cancel