Closed fsmunoz closed 3 weeks ago
@nimbinatus thank you for the review, I already accepted most of them, leaving the ones that require another pass (will address them now)
I've reflected most (if not all) of the contributions, thank you all! I've also changed the publication date as suggested.
Is there a PR to mirror this onto https://blog.k8s.io/ (I'd like there to be)
Is there a PR to mirror this onto https://blog.k8s.io/ (I'd like there to be)
Opened it here: https://github.com/kubernetes/website/pull/46454
/check-cla
/check-cla
echoing https://github.com/kubernetes/website/pull/46454#issuecomment-2123419126
/easycla
/hold
pending CLA issues being cleared on this and for https://github.com/kubernetes/website/pull/46454
Also, don't remove the hold if the listed publication date is in the past
@fsmunoz, this may have been affected by recent updates to EasyCLA.
@sftim apparently so since I've already sign the CLA 4 times in different repositories, and it works, but then changes back. I'll do it once more though.
I'll change the publication date to the 28th, is this OK?
@sftim validated with the author that this was a typo and the cgroug v1 was the intended version, as spotted by you.
/assign @SergeyKanzhelev @matthyx @gjkim42
@kubernetes/sig-contributor-experience-pr-reviews this is ready for a review
Mine isn't a critical review, but it looks good to me! /lgtm
@fsmunoz if you're minded to squash this down to 1 commit: even better.
@fsmunoz if you're minded to squash this down to 1 commit: even better.
Certainly; I will update the date and squash. Thanks!
LGTM from https://github.com/kubernetes/contributor-site/pull/498#issuecomment-2143012880 should stand.
/lgtm /approve
Please don't unhold yet.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fsmunoz, sftim
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
Add SIG Node Spotlight interview.
Closes: #497