search

kubernetes / dashboard

General-purpose web UI for Kubernetes clusters
Apache License 2.0
14.4k stars 4.16k forks source link

Ingress not allowed when kong is disabled #8972

Closed kajov closed 4 months ago

kajov commented 6 months ago

What happened?

setting kong to enabled: false causes error: template: kubernetes-dashboard/templates/networking/ingress.yaml:73:34: executing "kubernetes-dashboard/templates/networking/ingress.yaml" at <{{template "kong.fullname" (index $.Subcharts "kong")}}>: template "kong.fullname" not defined while app.ingress.enabled: true

The reason having this config: Running oAuth2-proxy with NGINX Ingress controller and external-dns to register new ingress targets created on Route53 for ALB to resolve

When kong and ingress are enabled and the ingress class has been created, ingress is causing too many redirects with 308 and cannot resolve into the target.

Request: When ingress is enabled, allow disabling Kong without relying on ingress enabled feature. Create missing k8s dashboard certificate as in previous versions for ingress tls as before

What did you expect to happen?

Disabling Kong wont interrupt deployment while having ingress enabled with external NGINX Ingress controller

How can we reproduce it (as minimally and precisely as possible)?

Due to complicated setup will only provide when necessary

Anything else we need to know?

Deployed using Helm Chart

What browsers are you seeing the problem on?

No response

Kubernetes Dashboard version

7.3.2

Kubernetes version

EKS 1.29

Dev environment

No response

floreks commented 5 months ago

I don't think that it makes much sense to disable kong and keep our ingress enabled. You'd need to completely overhaul the ingress configuration to make it work without kong. Are you sure you want to disable kong? You will need to match its functionality with something else.

floreks commented 4 months ago

Closing as stale. No response for ~1 month.

/close

k8s-ci-robot commented 4 months ago

@floreks: Closing this issue.

In response to [this](https://github.com/kubernetes/dashboard/issues/8972#issuecomment-2144732499): >Closing as stale. No response for ~1 month. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tbernacchi commented 3 months ago

Is there a way to turn off TLS on kubernetes-dashboard-kong-proxy? I was able to make it work setting --insecure-port on my kubernetes-dashboard-web deployment and then setting the certificate on my Ingress. What's the point to have this kubernetes-dashboard-kong-proxy?