search

kubernetes / dns

Kubernetes DNS service
Apache License 2.0
930 stars 468 forks source link

Bump golang to 1.21.3-bookworm to fix vulnerabilities #612

Closed DamianSawicki closed 1 year ago

DamianSawicki commented 1 year ago

/assign @kl52752

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DamianSawicki Once this PR has been reviewed and has the lgtm label, please ask for approval from kl52752. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/dns/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jingyuanliang commented 1 year ago

Not necessary to do this (I'd rather say "don't do this"). Just rebuild.

DamianSawicki commented 1 year ago

Ok, it is indeed not necessary to bump because the current tag golang:1.21-bookworm points to the same as the proposed tag golang:1.21.3-bookworm (see here), so if we build now there'll be no difference, and in the future the current tag will keep pointing to the latest patch version.