search

kubernetes / dns

Kubernetes DNS service
Apache License 2.0
930 stars 468 forks source link

Update e2e test images, fix test timeouts #651

Closed dereknola closed 3 weeks ago

dereknola commented 3 weeks ago

Changes

Linked Issues

https://github.com/kubernetes/dns/issues/646

k8s-ci-robot commented 3 weeks ago

Hi @dereknola. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dereknola commented 3 weeks ago

@DamianSawicki Can you approve this for "testing". Hopefully this should help resolve the prow test failures.

DamianSawicki commented 3 weeks ago

/ok-to-test

dereknola commented 3 weeks ago

Btw. how did you know that bumping hyperkube and etcd images would help?

I didn't, but it was the starting point for trying to fix stuff. Those images are horribly out of date, so bumping to latest versions would bring this repo in line with the rest of the K8s packages. I figured there might be some compatibility issues affecting the tests.

dereknola commented 3 weeks ago

@DamianSawicki I have bumped the related images as much as possible and left TODOs in areas that need future work.

DamianSawicki commented 3 weeks ago

@DamianSawicki I have bumped the related images as much as possible and left TODOs in areas that need future work.

Yeah, let's leave it to separate PRs. Thanks again for fixing the CI for kubernetes/dns!

/lgtm /assign @bowei

DamianSawicki commented 3 weeks ago

One more thing, please squash all these commits before merging with master (doesn't need to be done in advance, can be done during merging via the Squash and merge button).

EDIT: as @kl52752 pointed out to me on priv, PRs in this repo used to always auto-merge, so there won't be time to use the button Squash and merge, hence please squash in advance.

kl52752 commented 3 weeks ago

Thank you for your commit @dereknola :) Please squash your commits and we can merge this PR.

DamianSawicki commented 3 weeks ago

Thanks for squashing! I checked that the squashed version is identical to the previous one. Please approve @kl52752 or @bowei.

/lgtm

kl52752 commented 3 weeks ago

/approve /Lgtm

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DamianSawicki, dereknola, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/dns/blob/master/OWNERS)~~ [kl52752] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
DamianSawicki commented 3 weeks ago

EDIT: as @kl52752 pointed out to me on priv, PRs in this repo used to always auto-merge, so there won't be time to use the button Squash and merge, hence please squash in advance.

I guess it's the @k8s-ci-robot that is merging PRs in this repo, and not the native github auto-merge feature. It seems we can prevent it from doing so with the hold command (https://prow.k8s.io/command-help?repo=kubernetes%2Fdns) and then we could manually merge with Squash and merge in the future.